Skip to content
This repository has been archived by the owner on Mar 13, 2024. It is now read-only.

[MM-29927] Add discard when changing page after adding or removing user in system roles #7236

Merged

Conversation

hahmadia
Copy link
Contributor

@hahmadia hahmadia commented Dec 16, 2020

Summary

On the system roles page, if a user adds or removes a user to a role and switches pages, no "discard change" popup comes up. This PR fixes this issue where now a popup does show up after making this change.

Ticket Link

https://mattermost.atlassian.net/browse/MM-29927

@hahmadia hahmadia added 2: Dev Review Requires review by a core commiter 3: QA Review Requires review by a QA tester labels Dec 16, 2020
@hahmadia
Copy link
Contributor Author

/update-branch

@sbishel sbishel removed the 2: Dev Review Requires review by a core commiter label Dec 29, 2020
Copy link
Contributor

@furqanmlk furqanmlk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issue found, working as expected.
Manual and Cypress Test cases passed ✅
New test case has been created MM-T3663

@hahmadia hahmadia added 4: Reviews Complete All reviewers have approved the pull request and removed 3: QA Review Requires review by a QA tester labels Dec 30, 2020
@hahmadia hahmadia merged commit 8070bf8 into mattermost:master Dec 30, 2020
@hahmadia hahmadia deleted the MM-29927-AddDiscardToAddRemoveUser branch December 30, 2020 19:34
@amyblais amyblais added this to the v5.32.0 milestone Jan 4, 2021
@amyblais amyblais added Changelog/Done Required changelog entry has been written Docs/Not Needed Does not require documentation labels Jan 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
4: Reviews Complete All reviewers have approved the pull request Changelog/Done Required changelog entry has been written Docs/Not Needed Does not require documentation
Projects
None yet
6 participants