This repository has been archived by the owner on Mar 13, 2024. It is now read-only.
[MM-31358] Clicking 'Jump to recent' in an archived channel shouldn't redirect to town square #7235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devinbinnie
approved these changes
Dec 16, 2020
hmhealey
approved these changes
Dec 18, 2020
|
That makes sense to me. Hopefully we'll eventually get proper channel history instead of tracking the penultimate channel specifically which should make these sorts of things easier to prevent in the future. |
|
/update-branch |
jgilliam17
approved these changes
Jan 4, 2021
There was a problem hiding this comment.
Thank you @nickmisasi
Tested, looks good to merge.
- Verified user is taken to the bottom of the archived channel when clicking on history toast
after usingjumpfrom search results.
|
Test server destroyed |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Previously when jumping into an archived channel, if you clicked the "Jump to recents" toast, you'd be redirected out of the channel (provided you were significantly in the message history).
If you jump into a channel and are significantly into the message history, instead of scrolling down, the webapp will simply reload the page based on the localStorage last visited page value, which will result with the user at the most recent messages.
Since we were not storing archived channels in the last visited page value, when you clicked "Jump to recents" in an archived channel, you wouldn't be redirected to the same archived channel, but to some other one (usually town square).
Ticket Link
https://mattermost.atlassian.net/browse/MM-31358
Related Pull Requests
N/A
Screenshots
N/A