Commits on Feb 5, 2018

1. ABC-214: fix permalinks to direct messages …

   This simplifies the changes introduced in ABC-160 to simply check that
   the channel exists instead of also checking that the channel team id
   matches the current team. The additional check was redundant, since the
   set of channels available are already constrained to the current team;
   it was also wrong, since direct messages and group messages aren't
   actually assigned team ids, leading to the regression in question.
   
   Note that this check (before and even now) only works if you have access
   to the two teams in question. If you try to open a malformed permalink
   referencing a team for which you don't have access or that doesn't
   exist, none of the router code in <NeedsTeam> executes (team is null),
   and a different path is executed that doesn't try to evaluate the
   permalink. Fixing that appears to be non-trivial and out of scope for
   this change.

   

   lieut-data committed Feb 5, 2018
   Configuration menu

   • View commit details
   • Copy full SHA for 59282a5
   • Browse repository at this point

   Copy the full SHA

   59282a5 View commit details

   Browse the repository at this point in the history