Skip to content
This repository has been archived by the owner on Mar 13, 2024. It is now read-only.

[MM-27210] Archived channels 4 part I #7191

Merged
merged 7 commits into from
Dec 16, 2020
Merged

[MM-27210] Archived channels 4 part I #7191

merged 7 commits into from
Dec 16, 2020

Conversation

Willyfrog
Copy link
Contributor

Summary

MM-T1704
MM-T1705

Ticket Link

MM-27210

@Willyfrog Willyfrog added 2: Dev Review Requires review by a core commiter 3: QA Review Requires review by a QA tester labels Dec 9, 2020
@Willyfrog Willyfrog force-pushed the MM-27210_archived_channels_4_I branch from 7490496 to 04109b3 Compare December 9, 2020 16:07
@Willyfrog
Copy link
Contributor Author

noticed that it was skipping a lot of steps (or not showing them in the ui at least)
modified to show them also added 1 more test that was a repetition of the second one but being private.

This was referenced Dec 15, 2020
Merged
Closed
saturninoabril
saturninoabril approved these changes Dec 16, 2020
View reviewed changes
Copy link
Member

@saturninoabril saturninoabril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Willyfrog! Tested and all passed. LGTM.

@saturninoabril
Copy link
Member

/update-branch

@saturninoabril saturninoabril added 4: Reviews Complete All reviewers have approved the pull request AutoMerge used by Mattermod to merge PR automatically and removed 2: Dev Review Requires review by a core commiter 3: QA Review Requires review by a QA tester labels Dec 16, 2020
@mattermod
Copy link
Contributor

Will try to auto merge this PR once all tests and checks are passing. This might take up to an hour.

@mattermod
Copy link
Contributor

Trying to auto merge this PR.

@mattermod mattermod merged commit 82393e3 into mattermost:master Dec 16, 2020
@mattermod
Copy link
Contributor

Pull Request successfully merged
SHA: 82393e3

@mattermod mattermod removed the AutoMerge used by Mattermod to merge PR automatically label Dec 16, 2020
@amyblais amyblais added the Changelog/Not Needed Does not require a changelog entry label Dec 16, 2020
@amyblais amyblais added the Docs/Not Needed Does not require documentation label Dec 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hmhealey hmhealey hmhealey approved these changes

@saturninoabril saturninoabril saturninoabril approved these changes

Assignees
No one assigned
Labels
4: Reviews Complete All reviewers have approved the pull request Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Willyfrog @saturninoabril @mattermod @hmhealey @amyblais