Skip to content
This repository has been archived by the owner on Mar 13, 2024. It is now read-only.

PLT-8687: Changing team settings sends the user to Town Square #719

Merged
merged 3 commits into from
Feb 6, 2018
Merged

PLT-8687: Changing team settings sends the user to Town Square #719

merged 3 commits into from
Feb 6, 2018

Conversation

MusikPolice
Copy link
Contributor

Summary

Removed redirect when team settings are updated. As far as I can tell, this behaviour has been in place for a few releases now.

Ticket Link

https://mattermost.atlassian.net/browse/PLT-8687

Checklist

  • Ran make check-style to check for style errors (required for all pull requests)
  • Ran make test to ensure unit and component tests passed
  • Has UI changes

@MusikPolice MusikPolice added this to the v4.7.0 milestone Feb 5, 2018
hmhealey
hmhealey approved these changes Feb 6, 2018
View reviewed changes
Copy link
Member

@hmhealey hmhealey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd assume it's in place in case the name of the internal team changes, but I don't think you can even change that from the UI

@hmhealey hmhealey added the 4: Reviews Complete All reviewers have approved the pull request label Feb 6, 2018
@MusikPolice MusikPolice merged commit 3ada7bd into master Feb 6, 2018
@MusikPolice MusikPolice deleted the PLT-8687 branch February 6, 2018 19:09
@lindalumitchell lindalumitchell added the Tests/Done Release tests have been written label Feb 6, 2018
@amyblais amyblais added the Docs/Not Needed Does not require documentation label Feb 7, 2018
@amyblais amyblais added the Changelog/Not Needed Does not require a changelog entry label Feb 17, 2018
hmhealey pushed a commit that referenced this pull request Aug 28, 2020
@saturninoabril @hmhealey
[MM-13035 & MM-13068] Rearrange logic in sorting channels in the side…
fc68c08 
…bar (#719)

* rearrange logic in sorting channels in the sidebar

* remove console.log used while debugging
hmhealey pushed a commit that referenced this pull request Mar 17, 2021
@saturninoabril
[MM-13035 & MM-13068] Rearrange logic in sorting channels in the side…
3bf6840 
…bar (#719)

* rearrange logic in sorting channels in the sidebar

* remove console.log used while debugging
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mkraft mkraft mkraft approved these changes

@hmhealey hmhealey hmhealey approved these changes

Assignees
No one assigned
Labels
4: Reviews Complete All reviewers have approved the pull request Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation Tests/Done Release tests have been written
Projects
None yet
Milestone
v4.7.0
Development

Successfully merging this pull request may close these issues.
5 participants
@MusikPolice @mkraft @hmhealey @lindalumitchell @amyblais