Skip to content
This repository has been archived by the owner on Mar 13, 2024. It is now read-only.

[MM-30360] Cypress/E2E: Account settings #7185

Merged
merged 4 commits into from
Dec 17, 2020
Merged

Conversation

mickmister
Copy link
Member

Summary

For the Set user status test, there is a step that says to change the theme, and then verify that the icons appropriately change their styling to reflect the new theme. I wasn't sure how to accomplish this so it is not implemented at the moment.

Ticket Link

https://mattermost.atlassian.net/browse/MM-30360

  • MM-T2080 - Can remove profile pic

  • MM-T2088 - View and Logout of Active Sessions (Se)

  • MM-T2090 - Theme Colors: New theme color is saved

  • MM-T2927 - Set user status

@mickmister mickmister added 2: Dev Review Requires review by a core commiter 3: QA Review Requires review by a QA tester labels Dec 8, 2020
@DHaussermann
Copy link

DHaussermann commented Dec 9, 2020

@mickmister all test run green and seem in order. But, I'm not sure I understand your concern about the status color. These do change between light and dark theme.
Screen Shot 2020-12-09 at 11 37 18 AM

Can you verify in the DOM that these colors update? They don't always change but in some cases they vary and the negative space within the color updates.

Copy link
Member

@saturninoabril saturninoabril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mickmister! Tested and all passed. LGTM.
Heads up that we are transitioning to adopt more usage of testing-library with Cypress automation. There's an active documentation PR about it, especially on "which query to use". Next action from us is to update our codebase, one-by-one (per section of the app). Please consider looking at the guide in the future and let us know any feedback/comment.

Copy link

@DHaussermann DHaussermann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and passed
Test run green and follow TM4J scripts
LGTM!

@saturninoabril heads up that in this case there was no way to confirm the theme changing icon status with a reasonable amount of effort due to the way the icon color is inherited from CSS elsewhere. After speaking with @mickmister the validation around theme that is included seemed reasonable enough.

Updated status of TM4J tasks accordingly.

@DHaussermann DHaussermann added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core commiter 3: QA Review Requires review by a QA tester labels Dec 16, 2020
@mickmister
Copy link
Member Author

/update-branch

@mickmister mickmister added the AutoMerge used by Mattermod to merge PR automatically label Dec 17, 2020
@mattermod
Copy link
Contributor

Will try to auto merge this PR once all tests and checks are passing. This might take up to an hour.

@mickmister mickmister merged commit b569e23 into master Dec 17, 2020
@mickmister mickmister deleted the e2e-account-settings branch December 17, 2020 03:00
@mattermod mattermod removed the AutoMerge used by Mattermod to merge PR automatically label Dec 17, 2020
@amyblais amyblais added Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation labels Dec 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
4: Reviews Complete All reviewers have approved the pull request Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation
Projects
None yet
5 participants