Skip to content
This repository has been archived by the owner on Mar 13, 2024. It is now read-only.

ABC-55 User based rate limiting system console settings. #718

Merged
merged 1 commit into from
Feb 6, 2018
Merged

ABC-55 User based rate limiting system console settings. #718

merged 1 commit into from
Feb 6, 2018

Conversation

crspeller
Copy link
Member

No description provided.

@crspeller crspeller added the 2: Dev Review Requires review by a core commiter label Feb 5, 2018
lieut-data
lieut-data approved these changes Feb 5, 2018
View reviewed changes
Copy link
Member

@lieut-data lieut-data left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Unrelated to this change, but I often find myself going through page after page trying to find a particular configuration setting. Is there an appetite for a search feature (ala iOS), and/or possibly all the settings on a single page?

@hmhealey hmhealey added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core commiter labels Feb 6, 2018
@crspeller crspeller merged commit a4b4f98 into master Feb 6, 2018
@crspeller crspeller deleted the ABC-55 branch February 6, 2018 19:14
@amyblais amyblais added Changelog/Not Needed Does not require a changelog entry Docs/Needed Requires documentation Docs/Not Needed Does not require documentation and removed Docs/Needed Requires documentation labels Feb 6, 2018
@lindalumitchell lindalumitchell added the Tests/Done Release tests have been written label Feb 9, 2018
hmhealey pushed a commit that referenced this pull request Aug 28, 2020
@enahum @hmhealey
Action and reducers for pinned posts (#718)
797b8d6
hmhealey pushed a commit that referenced this pull request Mar 17, 2021
@enahum
Action and reducers for pinned posts (#718)
d553e20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lieut-data lieut-data lieut-data approved these changes

@hmhealey hmhealey hmhealey approved these changes

Assignees
No one assigned
Labels
4: Reviews Complete All reviewers have approved the pull request Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation Tests/Done Release tests have been written
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@crspeller @lieut-data @hmhealey @lindalumitchell @amyblais