[MM-31018] Update email address for admin advisor contact requests to [email protected]

[jasonblais]

Summary

Update email address for admin advisor contact requests to [email protected]

Ticket Link

https://mattermost.atlassian.net/browse/MM-31018

Related Pull Requests

mattermost/mattermost#16443

[jasonblais]

Please review carefully, to make sure I haven't missed a file.

@amyblais I would like to get this into v5.30 if possible. It is not a must-have though, so if I missed a code deadline, let me know and we'll queue for v5.31.

[amyblais]

This is for v5.31 - v5.30 will be based on the cloud release we did last week Tuesday - https://community-release.mattermost.com/private-core/pl/aa5m38ngg3dgfd6d3ma4pbbwne.

[jespino]

LGTM

[jasonblais]

/update-branch

[jasonblais]

@furqanmlk please help with QA review :)

[furqanmlk]

@furqanmlk please help with QA review :)
@jasonblais
I am in the process of review.
For some reason I don’t see expected email address. I will confirm with Rohit and update.
Sorry about the delay as I am new to this feature :)

[jasonblais]

All good :) If any questions, let me know

[furqanmlk]

Advisory Banner Acknowledge button still sending email to [email protected].
Please see the attachment for reference

Advisory Banner

Advisory Banner Mailto:email address

[furqanmlk]

Advisory Banner email us shows correct email address

[jasonblais]

@catalintomai is this something you can assist with as well? I'm not able to find where in the code we are setting the acknowledge button to send the email to [email protected]

[catalintomai]

@jasonblais , you will need to update the MM_SUPPORT_ADDRESS value in mattermost-server/model/config.go. cc: @furqanmlk

[jasonblais]

@catalintomai I assume this will change the email address for all other places where that constant is used? The intention is to only change it for the admin advisor notifications.

[catalintomai]

@catalintomai I assume this will change the email address for all other places where that constant is used? The intention is to only change it for the admin advisor notifications.

@jasonblais, I introduced the constant for AdminAdvisor purposes, fwik it is not used anywhere else.

[jasonblais]

That's great, thanks Catalin! I've made the update in the corresponding server PR: mattermost/mattermost#16443 (comment)

[furqanmlk]

Tested Contact Us and Email Us button are sending email to [email protected].
Test cases have been created for the same feature
MM-T3656

[jasonblais]

/update-branch

[jasonblais]

/update-branch

[jasonblais]

@catalintomai Any guidance on why the tests suddenly fail? No changes were made, other than updating to the master branch with /update-branch.

Otherwise the PR is ready to merge.

[catalintomai]

@jasonblais , you have to run a "make check-style" and address the errors. From the test results, it looks like there are some semicolons missing.

[jasonblais]

Thanks @catalintomai for the quick response. I actually made these changes via the UI and don't have the environment running locally to execute make check-style. That said, I only updated the email address and should have no missing semicolons.

[catalintomai]

@jasonblais - the failures are not related to your changes (you can click on the failure link above to get the exact set) - not clear how they made their way into master - I see the errors on my enlistment as well. I suspect they'll be fixed soon (tomorrow) and you should be able to check-in.

[jasonblais]

/update-branch

[mattermod]

Will try to auto merge this PR once all tests and checks are passing. This might take up to an hour.

[mattermod]

Trying to auto merge this PR.

[mattermod]

Pull Request successfully merged
SHA: d8b6d5f