This repository has been archived by the owner on Mar 13, 2024. It is now read-only.
[ICU-648-2] Fix scroll pop issue when viewing single images except of svg file type #709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grundleborg
approved these changes
Feb 5, 2018
hmhealey
approved these changes
Feb 5, 2018
hmhealey
added a commit
that referenced
this pull request
Aug 28, 2020
hmhealey
added a commit
that referenced
this pull request
Mar 17, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix scroll pop issue when viewing single images except of SVG file type
onload. It improves image loading.Note: Currently, SVG don't have height & width file info. Need to address separately (ticket: ICU-698).
Ticket Link
Jira ticket: ICU-648
Checklist
make check-styleto check for style errors (required for all pull requests)make testto ensure unit and component tests passed