This repository has been archived by the owner on Mar 13, 2024. It is now read-only.
ICU-687/ICU-688/ICU-689/ICU-690 Fixed channels staying in the UNREADS section after viewing #705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enahum
reviewed
Feb 2, 2018
| import {getUserIdsInChannels, getUser} from 'mattermost-redux/selectors/entities/users'; | ||
| import {get as getPreference} from 'mattermost-redux/selectors/entities/preferences'; | ||
| import {savePreferences} from 'mattermost-redux/actions/preferences'; | ||
| import {leaveChannel} from 'mattermost-redux/actions/channels'; | ||
| import {getConfig} from 'mattermost-redux/selectors/entities/general'; | ||
|
|
||
| import {keepChanneIdAsUnread} from 'actions/views/channel'; | ||
| import {clearKeepChannelIdAsUnread, keepChannelIdAsUnread} from 'actions/views/channel'; |
There was a problem hiding this comment.
didn't you remove the keepChannelIdAsUnread action?
jwilander
approved these changes
Feb 2, 2018
hmhealey
force-pushed
the
icu687
branch
2 times, most recently
from
5e5aed4
to
2f864d5
Compare
enahum
approved these changes
Feb 5, 2018
amyblais
added
Changelog/Done
hmhealey
pushed a commit
that referenced
this pull request
Aug 28, 2020
* MM-11839: Add ldap groups list/unlink/link actions (#705) * Adding the ldap groups count * Initial code for groups. * Fix for group members. * Fix for group syncables. * Removes commented code. * Adds group member count. * Adding getAllChannels and searchAllChannels calls to redux library * Adding unit tests to getAllChannels and searchAllChannels actions * Adds tests for new groups actions. * Fix some lint errors. * Flow fixes. * Adding pagination to get all channels * Adding store types and initial data for missing requests data * Switches from var to let or const. * Updates copy/paste error. * Removes unused action data. * Fix merge. * Moving webapp related reducers and selectors to the webapp * Adding RECEIVED_ALL_CHANNELS to channels reducers * Using simple funtions where selectors arent needed * Converted syncables groups selectors to plain functions * Fixed flow errors * Lockfile update. * Bad merge fixes.
hmhealey
pushed a commit
that referenced
this pull request
Mar 17, 2021
* MM-11839: Add ldap groups list/unlink/link actions (#705) * Adding the ldap groups count * Initial code for groups. * Fix for group members. * Fix for group syncables. * Removes commented code. * Adds group member count. * Adding getAllChannels and searchAllChannels calls to redux library * Adding unit tests to getAllChannels and searchAllChannels actions * Adds tests for new groups actions. * Fix some lint errors. * Flow fixes. * Adding pagination to get all channels * Adding store types and initial data for missing requests data * Switches from var to let or const. * Updates copy/paste error. * Removes unused action data. * Fix merge. * Moving webapp related reducers and selectors to the webapp * Adding RECEIVED_ALL_CHANNELS to channels reducers * Using simple funtions where selectors arent needed * Converted syncables groups selectors to plain functions * Fixed flow errors * Lockfile update. * Bad merge fixes.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It feels really good to fix 4 bugs with one fix. We were only updating the state that kept track of whether or not the current channel was in the unread section when you actually clicked on the items in the sidebar, so I changed it to trigger whenever you change channels.
As I discussed with Joram, I also changed one of the other reducers to use a new action instead of SELECT_CHANNEL to make it more clear that it needs additional information. At some point, we'll need to think about how this'll work when we start using more of the redux library's actions to switch channels.
This PR is on top of one of my other ones since they touch the same code, so the changes specific to this PR are here: icu686...icu687
Ticket Link
https://mattermost.atlassian.net/browse/ICU-687
https://mattermost.atlassian.net/browse/ICU-688
https://mattermost.atlassian.net/browse/ICU-689
https://mattermost.atlassian.net/browse/ICU-690