This repository has been archived by the owner on Mar 13, 2024. It is now read-only.
Plt 8299- updated removeEventEmmiters to addEE's so they work #702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephenkiers
commented
Feb 2, 2018
| hideEditChannelHeaderModal = () => { | ||
| this.setState({showEditChannelHeaderModal: false}); | ||
| } | ||
|
|
There was a problem hiding this comment.
This was a duplicate function
saturninoabril
approved these changes
Feb 2, 2018
hmhealey
added a commit
that referenced
this pull request
Aug 28, 2020
* MM-12827 Populate emoji and file state from post metadata (#689) * MM-12827 Don't load custom emoji for posts with metadata * MM-12827 Remove file and emoji metadata from stored posts * MM-12827 Populate emoji state from post metadata * MM-12827 Populate file state from post metadata * Add types for post metadata * Simplify getNeededCustomEmojis to only take an array and be clearer about skipping loading custom emojis * Properly handle a null posts argument for getProfilesAndStatusesForPosts * MM-12827 Populate reactions from post metadata (#691) * MM-12874 Store OpenGraph metadata in correct part of store (#702)
hmhealey
added a commit
that referenced
this pull request
Mar 17, 2021
* MM-12827 Populate emoji and file state from post metadata (#689) * MM-12827 Don't load custom emoji for posts with metadata * MM-12827 Remove file and emoji metadata from stored posts * MM-12827 Populate emoji state from post metadata * MM-12827 Populate file state from post metadata * Add types for post metadata * Simplify getNeededCustomEmojis to only take an array and be clearer about skipping loading custom emojis * Properly handle a null posts argument for getProfilesAndStatusesForPosts * MM-12827 Populate reactions from post metadata (#691) * MM-12874 Store OpenGraph metadata in correct part of store (#702)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The removeEventEmitters were trying to remove different funcs than the adds. So they did nothing, causing a fringe case leak
Ticket Link
https://mattermost.atlassian.net/browse/PLT-8299
Checklist
make check-styleto check for style errors (required for all pull requests)