Skip to content
This repository has been archived by the owner on Mar 13, 2024. It is now read-only.

Used a fragment to reduce code duplication in sidebar #699

Merged
merged 2 commits into from
Feb 2, 2018
Merged

Conversation

hmhealey
Copy link
Member

@hmhealey hmhealey commented Feb 2, 2018

This is a new feature of React that I don't think we've used yet. It lets you render a bunch of components without wrapping it in an extra div or span tag

@hmhealey hmhealey added the 2: Dev Review Requires review by a core commiter label Feb 2, 2018
@hmhealey hmhealey added this to the v4.7.0 milestone Feb 2, 2018
Copy link
Member

@jespino jespino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@hmhealey
Copy link
Member Author

hmhealey commented Feb 2, 2018

Merging this since it has 2 reviews and might conflict with something else I'm trying to fix

@hmhealey hmhealey merged commit 2b97f70 into master Feb 2, 2018
@hmhealey hmhealey removed the 2: Dev Review Requires review by a core commiter label Feb 2, 2018
@hmhealey hmhealey deleted the fragment branch February 2, 2018 22:27
@amyblais amyblais added Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation labels Feb 2, 2018
@lindalumitchell lindalumitchell added the Tests/Not Needed Does not require new release tests label Feb 3, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation Tests/Not Needed Does not require new release tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants