Skip to content
This repository has been archived by the owner on Mar 13, 2024. It is now read-only.

MM-T571 Integration search gives feed back when there are no results. #6922

Merged
merged 21 commits into from
Oct 29, 2020

Conversation

MikeworX
Copy link
Contributor

@MikeworX MikeworX commented Oct 26, 2020

Summary

This pr validates that a search message appears on the integrations page that contains the search term, when there are no results, when the window has been shrunken.

Steps

  • two each of incoming web-hooks, outgoing web-hooks, slash command, and bot accounts are created in the before hook
  • the integrations page is visited
  • the browser window is reduced to a small size
  • a search that will return results is performed and it is asserted that the no results message does not exist
  • a search is then performed with a random string that will return no results, and the no results message is asserted to be present for each search type

Screen Shot 2020-10-26 at 2 26 01 PM

Links

vercel
TM4J

@mattermod
Copy link
Contributor

Hello @MikeworX,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

@MikeworX MikeworX marked this pull request as ready for review October 26, 2020 19:04
@jasonblais jasonblais added 2: Dev Review Requires review by a core commiter 3: QA Review Requires review by a QA tester labels Oct 26, 2020
@prapti
Copy link
Contributor

prapti commented Oct 27, 2020

/update-branch

Copy link
Contributor

@prapti prapti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test passed and the spec file looks good to me. Thank you @MikeworX!

Copy link
Member

@saturninoabril saturninoabril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @MikeworX! Please see comments.

Copy link
Member

@saturninoabril saturninoabril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @MikeworX! LGTM.

@saturninoabril saturninoabril added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core commiter 3: QA Review Requires review by a QA tester labels Oct 29, 2020
@saturninoabril saturninoabril merged commit 9658b30 into mattermost:master Oct 29, 2020
@MikeworX MikeworX deleted the integration_search_feedback branch October 29, 2020 13:20
@amyblais amyblais added Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation labels Oct 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
4: Reviews Complete All reviewers have approved the pull request Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation Hacktoberfest hacktoberfest-accepted
Projects
None yet
6 participants