This repository has been archived by the owner on Mar 13, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
MM-T571 Integration search gives feed back when there are no results. #6922
Merged
saturninoabril
merged 21 commits into
mattermost:master
from
MikeworX:integration_search_feedback
Oct 29, 2020
Merged
MM-T571 Integration search gives feed back when there are no results. #6922
saturninoabril
merged 21 commits into
mattermost:master
from
MikeworX:integration_search_feedback
Oct 29, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updating fork
/update-branch |
prapti
approved these changes
Oct 27, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test passed and the spec file looks good to me. Thank you @MikeworX!
saturninoabril
suggested changes
Oct 27, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @MikeworX! Please see comments.
e2e/cypress/integration/integrations/integrations_search_gives_feedback_spec.js
Outdated
Show resolved
Hide resolved
e2e/cypress/integration/integrations/integrations_search_gives_feedback_spec.js
Outdated
Show resolved
Hide resolved
e2e/cypress/integration/integrations/integrations_search_gives_feedback_spec.js
Outdated
Show resolved
Hide resolved
e2e/cypress/integration/integrations/integrations_search_gives_feedback_spec.js
Outdated
Show resolved
Hide resolved
e2e/cypress/integration/integrations/integrations_search_gives_feedback_spec.js
Outdated
Show resolved
Hide resolved
e2e/cypress/integration/integrations/integrations_search_gives_feedback_spec.js
Outdated
Show resolved
Hide resolved
e2e/cypress/integration/integrations/integrations_search_gives_feedback_spec.js
Outdated
Show resolved
Hide resolved
…worX/mattermost-webapp into integration_search_feedback
saturninoabril
suggested changes
Oct 28, 2020
e2e/cypress/integration/integrations/integrations_search_gives_feedback_spec.js
Show resolved
Hide resolved
saturninoabril
approved these changes
Oct 29, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @MikeworX! LGTM.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
4: Reviews Complete
All reviewers have approved the pull request
Changelog/Not Needed
Does not require a changelog entry
Docs/Not Needed
Does not require documentation
Hacktoberfest
hacktoberfest-accepted
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pr validates that a search message appears on the integrations page that contains the search term, when there are no results, when the window has been shrunken.
Steps
Links
vercel
TM4J