Skip to content
This repository has been archived by the owner on Mar 13, 2024. It is now read-only.

[ICU-648] Fix download tooltip #692

Merged
merged 4 commits into from
Feb 6, 2018
Merged

[ICU-648] Fix download tooltip #692

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
562a7f5
fix download tooltip
saturninoabril Jan 31, 2018
cb6ece9
change text to `Download` only and change tooltip position closer to …
saturninoabril Feb 2, 2018
515e65a
fix conflicts
saturninoabril Feb 5, 2018
92cd8e0
removed unnecessary props and add constant for max filename length
saturninoabril Feb 6, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
change text to Download only and change tooltip position closer to … 
…download icon
  • Loading branch information
@saturninoabril
saturninoabril committed Feb 5, 2018
commit cb6ece951d83a5911ed7ce3e4d2a4883281dc1f0
34 changes: 17 additions & 17 deletions components/file_attachment/filename_overlay.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,26 +99,26 @@ export default class FilenameOverlay extends React.PureComponent {
);
} else if (canDownload) {
filenameOverlay = (
<OverlayTrigger
trigger={['hover', 'focus']}
delayShow={1000}
placement='top'
overlay={
<Tooltip id='file-name__tooltip'>
{localizeMessage('file_attachment.download', 'Download') + ' "' + fileName + '"'}
</Tooltip>
}
<a
href={fileUrl}
download={fileName}
className={iconClass || 'post-image__name'}
target='_blank'
rel='noopener noreferrer'
>
<a
href={fileUrl}
download={fileName}
className={iconClass || 'post-image__name'}
target='_blank'
rel='noopener noreferrer'
<OverlayTrigger
trigger={['hover', 'focus']}
delayShow={1000}
placement='top'
overlay={
<Tooltip id='file-name__tooltip'>
{localizeMessage('file_attachment.download', 'Download')}
</Tooltip>
}
>
{children || trimmedFilename}
</a>
</OverlayTrigger>
</OverlayTrigger>
</a>
);
} else {
filenameOverlay = (
Expand Down