Skip to content
This repository has been archived by the owner on Mar 13, 2024. It is now read-only.

[PLT-8662] Fix paste upload issue #686

Merged
merged 1 commit into from
Feb 5, 2018
Merged

[PLT-8662] Fix paste upload issue #686

merged 1 commit into from
Feb 5, 2018

Conversation

saturninoabril
Copy link
Member

Summary

Fix paste upload issue

When image from clipboard is pasted into the post textbox, the filename of the image gets posted to the textbox as well. Not sure if that's expected but maybe worth checking from the PM.
@esethna Could you please help validate? Thanks!

Ticket Link

Jira ticket: PLT-8662

Checklist

  • Ran make check-style to check for style errors (required for all pull requests)
  • Ran make test to ensure unit and component tests passed

@saturninoabril saturninoabril added 1: PM Review Requires review by a product manager Setup Old Test Server Triggers the creation of a test server labels Jan 31, 2018
@saturninoabril saturninoabril added Awaiting Submitter Action Blocked on the author and removed 1: PM Review Requires review by a product manager Setup Old Test Server Triggers the creation of a test server labels Jan 31, 2018
Copy link
Contributor

@stephenkiers stephenkiers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Undoing approval, as it seems it is not complete

@mattermod
Copy link
Contributor

Setup Test Server label detected. Spinmint test server created if build succeeds (checks pass and no conflicts with base branch).

@saturninoabril saturninoabril added 1: PM Review Requires review by a product manager Setup Old Test Server Triggers the creation of a test server and removed Awaiting Submitter Action Blocked on the author labels Feb 2, 2018
@mattermod
Copy link
Contributor

Spinmint test server created at: https://i-0fe79ab6f3543dfae.spinmint.com

Test Admin Account: Email: [email protected] | Password: user-0

Test User Account: Email: [email protected] | Password: user-1

@saturninoabril
Copy link
Member Author

@stephenkiers Yeah, I'm seeing issue when pasting image but not sure if we support it or a regression. I've tried older version but looks the same behavior. Issues like:

  • copying image file from local and pasting to textbox uploads the image but filename is pasted into the textbox as well
  • same when I copy image from the web (e.g. google image), the image uploads but the link is also pasted into the textbox

@esethna Could you please test pasting images and let me know what issues that needs to resolve? Thanks!

@esethna esethna added 2: Dev Review Requires review by a core commiter and removed 1: PM Review Requires review by a product manager Setup Old Test Server Triggers the creation of a test server labels Feb 2, 2018
Copy link
Contributor

@esethna esethna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, ie image should paste without text being added to the input box

@stephenkiers stephenkiers added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core commiter labels Feb 5, 2018
@saturninoabril saturninoabril merged commit 31dbe63 into mattermost:master Feb 5, 2018
@saturninoabril saturninoabril deleted the PLT-8662 branch February 5, 2018 16:38
@amyblais amyblais added Changelog/Done Required changelog entry has been written Docs/Not Needed Does not require documentation labels Feb 6, 2018
@lindalumitchell lindalumitchell added the Tests/Done Release tests have been written label Feb 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
4: Reviews Complete All reviewers have approved the pull request Changelog/Done Required changelog entry has been written Docs/Not Needed Does not require documentation Tests/Done Release tests have been written
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants