This repository has been archived by the owner on Mar 13, 2024. It is now read-only.
[MM-24963] Fix inconsistent hover/tooltips UX #6853
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calebroseland
added
2: Dev Review
calebroseland
changed the title
hmhealey
approved these changes
Oct 20, 2020
jfrerich
approved these changes
Oct 21, 2020
|
/update-branch |
calebroseland
added
the
Setup Cloud Test Server
jgilliam17
approved these changes
Oct 23, 2020
There was a problem hiding this comment.
Thank you @calebroseland
Tested, looks good to merge.
- Verified tooltip appears on hover as cursor changes to pointer. Verified the list of items listed in accompanying jira ticket.
jgilliam17
added
4: Reviews Complete
|
Test server destroyed |
calebroseland
added a commit
that referenced
this pull request
Oct 27, 2020
* invert overlays/btns * hide overlay when disabled * simplify, invert remaining triggers * invert filter-unread overlay/button Co-authored-by: Mattermod <[email protected]>
amyblais
added
Changelog/Not Needed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
A number of
<OverlayTrigger/>s are inside their corresponding buttons/links. This can cause a discrepancy between the CSS hover state and activation of said trigger (some imperceivable, others noticeable, depending on the padding/styling). This PR inverts these so the buttons/links are inside<OverlayTrigger/>.<OverlayTrigger/>: newdisabledprop to disable overlay content from being displayed viavisibility: hidden(prevents positional glitches vs. wholly removing from DOM)e.g. turning off the tooltip of a button that also has a popover/content overlay.
The overriding
show=falsein[email protected]+could replace this if/when upgraded.