Skip to content
This repository has been archived by the owner on Mar 13, 2024. It is now read-only.

[MM-29687] Migrate call to changeCSS() for '.app__body .user-popover__role' #6812

Conversation

seongwon-kang
Copy link
Contributor

@seongwon-kang seongwon-kang commented Oct 16, 2020

Summary

Fixes #15962, MM-29687

Ticket Link

Github Issue: Fixes mattermost/mattermost#15962
JIRA Ticket: MM-29687

@mattermod
Copy link
Contributor

Hello @seongwon-kang,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

@seongwon-kang seongwon-kang changed the title Migrate call to changeCSS() for '.app__body .user-popover__role' [MM-29687] Migrate call to changeCSS() for '.app__body .user-popover__role' Oct 16, 2020
@lindy65 lindy65 added the 2: Dev Review Requires review by a core commiter label Oct 16, 2020
sass/components/_popover.scss Outdated Show resolved Hide resolved
@seongwon-kang
Copy link
Contributor Author

Sorry, I moved entire .user-popover__role in .app__body, so I force-pushed commit that only adds background property.

@Willyfrog Willyfrog merged commit ae59a77 into mattermost:campaign/applytheme_center-channel-color Oct 21, 2020
@Willyfrog Willyfrog added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core commiter labels Oct 21, 2020
@amyblais amyblais added Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation labels Oct 21, 2020
deanwhillier pushed a commit that referenced this pull request Oct 27, 2021
Fixes #15962, MM-29687
# Conflicts:
#	sass/components/_popover.scss
#	utils/utils.jsx
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
4: Reviews Complete All reviewers have approved the pull request Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation Hacktoberfest hacktoberfest-accepted
Projects
None yet
6 participants