Skip to content
This repository has been archived by the owner on Mar 13, 2024. It is now read-only.

Cypress/E2E: Fix require license on some system console specs #6802

Merged
merged 2 commits into from
Oct 16, 2020
Merged

Cypress/E2E: Fix require license on some system console specs #6802

merged 2 commits into from
Oct 16, 2020

Conversation

josephbaylon
Copy link
Contributor

Summary

Ticket Link

NA

@josephbaylon josephbaylon added the 3: QA Review Requires review by a QA tester label Oct 15, 2020
srkgupta
srkgupta suggested changes Oct 15, 2020
View reviewed changes
Copy link
Contributor

@srkgupta srkgupta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @josephbaylon. Couple of suggestions.

e2e/cypress/integration/system_console/reporting/site_statistics_spec.js Outdated Show resolved Hide resolved
e2e/cypress/integration/system_console/search_box_spec.js Show resolved Hide resolved
srkgupta
srkgupta approved these changes Oct 15, 2020
View reviewed changes
Copy link
Contributor

@srkgupta srkgupta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @josephbaylon. Changes LGTM

saturninoabril
saturninoabril approved these changes Oct 16, 2020
View reviewed changes
Copy link
Member

@saturninoabril saturninoabril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @josephbaylon!

e2e/cypress/integration/system_console/main_menu_spec.js Show resolved Hide resolved
@saturninoabril saturninoabril added 4: Reviews Complete All reviewers have approved the pull request and removed 3: QA Review Requires review by a QA tester labels Oct 16, 2020
@saturninoabril saturninoabril merged commit d02a0c8 into mattermost:master Oct 16, 2020
@amyblais amyblais added Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation labels Oct 16, 2020
@josephbaylon josephbaylon deleted the fix-require-license-system-console branch October 16, 2020 15:31
jfrerich pushed a commit that referenced this pull request Oct 23, 2020
@jfrerich
Cypress/E2E: Fix require license on some system console specs (#6802)
12a7881 
* Cypress/E2E: Fix require license on some system console specs

* Moved locale rester to afterEach
calebroseland pushed a commit that referenced this pull request Oct 27, 2020
@calebroseland
Cypress/E2E: Fix require license on some system console specs (#6802)
36d4fa0 
* Cypress/E2E: Fix require license on some system console specs

* Moved locale rester to afterEach
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@srkgupta srkgupta srkgupta approved these changes

@saturninoabril saturninoabril saturninoabril approved these changes

Assignees
No one assigned
Labels
4: Reviews Complete All reviewers have approved the pull request Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation
Projects
None yet
Milestone
No milestone
4 participants
@josephbaylon @srkgupta @saturninoabril @amyblais