This repository has been archived by the owner on Mar 13, 2024. It is now read-only.
MM-28833 Remove computed details from getChannel selector #6794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hmhealey
added
2: Dev Review
hmhealey
commented
Oct 14, 2020
| @@ -53,7 +53,6 @@ function makeMapStateToProps() { | |||
| return { | |||
| lastViewedAt, | |||
| channelLoading, | |||
| channel, | |||
There was a problem hiding this comment.
This isn't actually used by the component
| @@ -27,11 +26,10 @@ function makeMapStateToProps() { | |||
| const selected = getSelectedPost(state); | |||
| const socketStatus = getSocketStatus(state); | |||
|
|
|||
| let channel = null; | |||
| const channel = getSelectedChannel(state); | |||
There was a problem hiding this comment.
We can get the selected channel directly from the store instead of having to infer it from the selected post to simplify things slightly
hmhealey
added
the
Do Not Merge/Awaiting PR
nevyangelova
approved these changes
Oct 15, 2020
hmhealey
requested review from
sudheerDev
and removed request for
deanwhillier
sudheerDev
approved these changes
Oct 21, 2020
hmhealey
added
Setup Cloud Test Server
mm-cloud-bot
removed
the
Setup Cloud Test Server
hanzei
added
the
Setup Cloud Test Server
jgilliam17
approved these changes
Oct 28, 2020
There was a problem hiding this comment.
Thank you @hmhealey
Tested, looks good to merge.
- Verified DM & GM headers, DMs in channels switcher, channel names in RHS and search results and GM channel names in desktop notifications.
jgilliam17
added
4: Reviews Complete
|
Test server destroyed |
|
Test server creation failed. See the logs for more information. |
hmhealey
removed
the
Do Not Merge/Awaiting PR
amyblais
added
Changelog/Not Needed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As I mentioned earlier this week,
getChannelis problematic because its a selector that takes an argument without being behind a factory function, so if you have two or more components both using it, they'll constantly be overwriting each others' results, leading to those components re-rendering constantly. The main reason that this causes problems is thatgetChannelreturns a new object each time for DMs and GMs because it adds on some additional derived fields such as the dynamic display_name for DM and GM channels. On the current version of master, this leads to things like parts of the new sidebar and all of the RHS re-rendering constantly.I changed
getChannelto be a plain function that doesn't compute any data so that it can be re-used easily wherever we don't need the computed fields, and I've usedmakeGetChannelto generate one-off selectors for everywhere that does need that data.Ticket Link
https://mattermost.atlassian.net/browse/MM-28833
Related Pull Requests
mattermost/mattermost-redux#1257