This repository has been archived by the owner on Mar 13, 2024. It is now read-only.
[MM-29651] Wait for async calls to finish before rendering anything for a couple billing screens #6780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or a couple billing screens
alifarooq0
approved these changes
Oct 14, 2020
There was a problem hiding this comment.
@devinbinnie are you referring to the billing history screen?
Yes :D |
marianunez
approved these changes
Oct 14, 2020
devinbinnie
added
4: Reviews Complete
|
/cherry-pick cloud-ga |
|
Cherry pick is scheduled. |
mattermost-build
pushed a commit
to mattermost-build/mattermost-webapp
that referenced
this pull request
Oct 14, 2020
…or a couple billing screens (mattermost#6780) (cherry picked from commit c44e96d)
mattermod
added
the
CherryPick/Done
devinbinnie
added a commit
that referenced
this pull request
Oct 14, 2020
…or a couple billing screens (#6780) (#6782) (cherry picked from commit c44e96d) Co-authored-by: Devin Binnie <[email protected]>
amyblais
added
Changelog/Not Needed
jfrerich
pushed a commit
that referenced
this pull request
Oct 23, 2020
…or a couple billing screens (#6780)
calebroseland
pushed a commit
that referenced
this pull request
Oct 27, 2020
…or a couple billing screens (#6780)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a flash that occurs on the Subscriptions and Payment Info screens when the information hasn't finished loading, but the component has rendered.
NOTE: I couldn't fix the billing history screen, see JIRA ticket for explanation.
Ticket Link
https://mattermost.atlassian.net/browse/MM-29651