This repository has been archived by the owner on Mar 13, 2024. It is now read-only.
[MM-29632] Added extra null checking for company address #6777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marianunez
reviewed
Oct 14, 2020
Co-authored-by: Maria A Nunez <[email protected]>
marianunez
approved these changes
Oct 14, 2020
nickmisasi
approved these changes
Oct 14, 2020
|
/cherry-pick cloud-ga |
|
Cherry pick is scheduled. |
mattermost-build
pushed a commit
to mattermost-build/mattermost-webapp
that referenced
this pull request
Oct 14, 2020
…6777) * [MM-29632] Added extra null checking for company address * Update components/admin_console/billing/company_info_display.tsx Co-authored-by: Maria A Nunez <[email protected]> Co-authored-by: Maria A Nunez <[email protected]> (cherry picked from commit 1dd306c)
devinbinnie
added a commit
that referenced
this pull request
Oct 14, 2020
* [MM-29632] Added extra null checking for company address * Update components/admin_console/billing/company_info_display.tsx Co-authored-by: Maria A Nunez <[email protected]> Co-authored-by: Maria A Nunez <[email protected]> (cherry picked from commit 1dd306c) Co-authored-by: Devin Binnie <[email protected]>
jfrerich
pushed a commit
that referenced
this pull request
Oct 23, 2020
* [MM-29632] Added extra null checking for company address * Update components/admin_console/billing/company_info_display.tsx Co-authored-by: Maria A Nunez <[email protected]> Co-authored-by: Maria A Nunez <[email protected]>
calebroseland
pushed a commit
that referenced
this pull request
Oct 27, 2020
* [MM-29632] Added extra null checking for company address * Update components/admin_console/billing/company_info_display.tsx Co-authored-by: Maria A Nunez <[email protected]> Co-authored-by: Maria A Nunez <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the case where the
company_addressfield isnullbut thebilling_addressis not but still contains no data. A white screen would appear.Ticket Link
https://mattermost.atlassian.net/browse/MM-29632