This repository has been archived by the owner on Mar 13, 2024. It is now read-only.
ABC-122 Handle custom emojis in channel header and login page #677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jespino
reviewed
Feb 1, 2018
| onClick={Utils.handleFormattedTextClick} | ||
| dangerouslySetInnerHTML={{__html: TextFormatting.formatText(channel.header, textFormattingOptions)}} | ||
| /> | ||
| <span>{messageHtmlToComponent(formattedText, false, {mentions: false})}</span> |
There was a problem hiding this comment.
I think here the handleFormattedTextClick is still needed. For example, I can't click a hashtag link.
There was a problem hiding this comment.
Oh yeah, that was an accidental removal. I'll add it back
saturninoabril
approved these changes
Feb 1, 2018
|
@jespino fixed |
jespino
approved these changes
Feb 2, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Based on #673.
Ticket Link
https://mattermost.atlassian.net/browse/ABC-122
Checklist
make check-styleto check for style errors (required for all pull requests)make testto ensure unit and component tests passed