add online status

[ghost]

Summary

This ticket add online status to user autocomplete

Ticket Link

JIRA: https://mattermost.atlassian.net/browse/MM-26803

[mattermod]

Hello @Prescise,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

[esethna]

@Prescise looks like the checkmark and sizing might be off, adding @matthewbirtch for a UX review

[matthewbirtch]

Thanks for the work on this @Prescise. A few things:

1. It looks like we're not showing the display name here. In the screenshot below, we should see "Matthew Birtch" to the left of the status icon and the username "matthew.birtch" in grey to the right of the status icon.

2. There is too much space between the status icon and the grey text to the right

3. The status icon should 12x12 not 14x14.

4. The status icon it looks like it's sitting 1px too low to be properly centered

5. The status icons need to be updated to the new style across the board - although, this is likely outside of the scope of this ticket. We will probably want to create a separate ticket to update icons across the app, so don't worry about this for now.

6. For 'special mentions', I'm not sure why my username is showing (see screenshot below). Right now, it's showing 'matthew.birtch' instead of '@here', '@ALL', '@channel'. Also, we shouldn't show the status icon for the special mentions

7. Actually, it seems like the current user's username is being used for every row item in the list (see screenshot below)

Implemented

Designed

7. The nickname should show in brackets after the display name. For example: "Matthew Birtch (Matt) • matthew.birtch (you)".
   

[esethna]

@Prescise how's this going?

[mattermod]

This PR has been automatically labelled "stale" because it hasn't had recent activity.
A core team member will check in on the status of the PR to help with questions.
Thank you for your contribution!

/cc @jasonblais @jfrerich @emilyacook

[jfrerich]

Hi, @Prescise! How's the PR going? It's been a while since we've seen an update. This is a great contribution. If you have any questions, please feel free to ping the reviewers for help!

[esethna]

@Prescise let us know if you're still working on this :)

[ghost]

Hi @esethna I'm very sorry, but I'm on another project that my team and I are working on for our client, we have to finish it by the end of December and I really didn't have the time for open source, I'll try to find 1 hour and fix it this week.

[esethna]

@Prescise appreciate it!

[mattermod]

This PR has been automatically labelled "stale" because it hasn't had recent activity.
A core team member will check in on the status of the PR to help with questions.
Thank you for your contribution!

/cc @jasonblais @jfrerich @emilyacook

[esethna]

@Prescise hope all is well. We're you able to find some time to work through the changes requested? Looking forward to getting this in!

[esethna]

@Prescise let us know if you're still working on this, perhaps @asaadmahmood can help push it across the finish line

[ghost]

@esethna Hi I'm very sorry, yes no pb for me, I cannot work on it now.

[esethna]

No worries. @asaadmahmood would you be able to finish this PR off?

[asaadmahmood]

@esethna Suer, I haven't had a look at it, but I can and see if I can get it to the finish line.

[esethna]

Gentle ping on this one @asaadmahmood, thx!

[asaadmahmood]

@esethna Will have a look in a while hopefully. Was working on the other PR.

[angeloskyratzakos]

Hey all, I will remove the tag Setup Cloud Test Server for maintenance reasons. Feel free to re-add it when you need it. Thank you

[mm-cloud-bot]

Test server destroyed

[esethna]

Ping @asaadmahmood on this one when you have a chance!

[matthewbirtch]

@esethna @asaadmahmood I think we should close this PR or rework it so that we move the status overlapped on top of the avatar - like we do on the channel switcher now.

[asaadmahmood]

@matthewbirtch Yup, we can do that, though I prefer it not on top of the avatar in this case, as it obstructs the image too much. But I'm fine if that's what we end up deciding.

[matthewbirtch]

@matthewbirtch Yup, we can do that, though I prefer it not on top of the avatar in this case, as it obstructs the image too much. But I'm fine if that's what we end up deciding.

Ya, I think it's a consistency thing. Since we now have the status overlapping the avatar in the LHS and in the channel switcher (as well as other places), we now have a pattern that I think we should follow. Users should see the status in the same place as much as possible, so I think we should move forward with this.

[asaadmahmood]

Sounds cool. @matthewbirtch I can still take this, and design it similar to what we have in the LHS.
So no worries on this.

[esethna]

@asaadmahmood would you prefer to edit this PR or close and re-open? Feel free to do it :)

[asaadmahmood]

@esethna I can probably take this.

[mm-cloud-bot]

@Prescise: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

I understand the commands that are listed here

[mattermod]

This PR has been automatically labelled "stale" because it hasn't had recent activity.
A core team member will check in on the status of the PR to help with questions.
Thank you for your contribution!

/cc @jasonblais @jfrerich @emilyacook

[lieut-data]

Heads up that as part of our efforts to move to a monorepo, we're closing out a number of older pull requests like this one to help streamline the effort.

If you'd like to preserve these changes -- even if you're not the original author! -- feel free to resubmit the pull request against the monorepo once it's ready. You can subscribe to mattermost-server-issue-22420 for status updates on this effort.