Skip to content
This repository has been archived by the owner on Mar 13, 2024. It is now read-only.

[GH-15871] Migrate changeCSS() to CSS variable in utils/utils.jsx, ln. 559 #6701

Merged
merged 1 commit into from
Oct 21, 2020
Merged

[GH-15871] Migrate changeCSS() to CSS variable in utils/utils.jsx, ln. 559 #6701

merged 1 commit into from
Oct 21, 2020

Conversation

arc9693
Copy link
Contributor

@arc9693 arc9693 commented Oct 8, 2020

Summary

Migrate changeCSS() to CSS variable in utils/utils.jsx, ln. 559

Ticket Link

Closes mattermost/mattermost#15871

@mattermod
Copy link
Contributor

Hello @arc9693,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

@arc9693 arc9693 changed the title Remove usage of cssChange() for navbrand color [GH-15871] Migrate changeCSS() to CSS variable in utils/utils.jsx, ln. 559 Oct 8, 2020
@hanzei hanzei added the 2: Dev Review Requires review by a core commiter label Oct 8, 2020
@lindy65 lindy65 added the 3: QA Review Requires review by a QA tester label Oct 9, 2020
asaadmahmood
asaadmahmood suggested changes Oct 12, 2020
View reviewed changes
Copy link
Contributor

@asaadmahmood asaadmahmood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We already have the .navbar-brand rule defined in the file, it would be better if we reuse that instead of creating a duplicate .navbar-brand rule.

And then you can define the .app__body inside it like this:

.navbar-brand {
    .app__body & {
    }
}

@deanwhillier
Copy link
Contributor

QA will be done for this PR in batch when the campaign branch is merged into master

@deanwhillier deanwhillier removed the 3: QA Review Requires review by a QA tester label Oct 13, 2020
@arc9693 arc9693 force-pushed the campaign/applytheme_sidebar-header-text-color branch 3 times, most recently from 2c5a582 to 97883cc Compare October 15, 2020 16:33
@arc9693 arc9693 force-pushed the campaign/applytheme_sidebar-header-text-color branch from 97883cc to e6fc714 Compare October 15, 2020 16:42
@arc9693
Copy link
Contributor Author

arc9693 commented Oct 15, 2020

@asaadmahmood I have made the changes.

@hanzei hanzei added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core commiter labels Oct 21, 2020
@hanzei hanzei added this to the v5.30.0 milestone Oct 21, 2020
@hanzei hanzei merged commit 62eed45 into mattermost:campaign/applytheme_sidebar-header-text-color Oct 21, 2020
@hanzei hanzei mentioned this pull request Oct 21, 2020
Closed
@hanzei
Copy link
Contributor

hanzei commented Oct 21, 2020

Thank you for the contribution @arc9693 👍

@amyblais amyblais added Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation labels Oct 21, 2020
deanwhillier pushed a commit that referenced this pull request Jan 22, 2021
@arc9693 @deanwhillier
[GH-15871] Migrate changeCSS() to CSS variable in utils/utils.jsx, ln…
b674b3d 
…. 559 (#6701)
deanwhillier added a commit that referenced this pull request Jan 27, 2021
@deanwhillier @xaylax
@haardikdharma10 @ashutosh97 @arc9693 @mattermod
Campaign/applytheme sidebar header text color (#7379)
eec30f1 
* [GH-15875] Migrate changeCSS() to CSS variable in utils/utils.jsx, ln. 564 (#6745)

* [MM-29461] Migrate changeCSS() to CSS variable in utils/utils.jsx in 560. (#6720)

* Migrate changeCSS() to CSS variable in utils/utils.jsx in 560.

* Update _navigation.scss

* [GH-15873] Migrate changeCSS() to CSS variable in utils/utils.jsx, ln. 562 (#6703)

* Switch from cssChange() for team-btn border-color

* Moved css to existing class

* [GH-15871] Migrate changeCSS() to CSS variable in utils/utils.jsx, ln. 559 (#6701)

* Address MM-29463

Co-authored-by: AO <[email protected]>
Co-authored-by: Haardik Dharma <[email protected]>
Co-authored-by: Ashutosh Agarwal <[email protected]>
Co-authored-by: Archana Choudhary <[email protected]>
Co-authored-by: Mattermod <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@asaadmahmood asaadmahmood asaadmahmood approved these changes

@nevyangelova nevyangelova nevyangelova approved these changes

Assignees
No one assigned
Labels
4: Reviews Complete All reviewers have approved the pull request Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation Hacktoberfest hacktoberfest-accepted
Projects
None yet
Milestone
v5.30.0
Development

Successfully merging this pull request may close these issues.
8 participants
@arc9693 @mattermod @deanwhillier @hanzei @asaadmahmood @nevyangelova @lindy65 @amyblais