This repository has been archived by the owner on Mar 13, 2024. It is now read-only.
[MM-28257] Cypress/E2E: Automate backlogs - Integrations > Slash Commands (10 test cases) #6638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saturninoabril
suggested changes
Oct 8, 2020
e2e/cypress/integration/integrations/builtin_commands/common_commands_spec.js
Show resolved
Hide resolved
e2e/cypress/integration/integrations/builtin_commands/common_commands_spec.js
Outdated
Show resolved
Hide resolved
e2e/cypress/integration/integrations/builtin_commands/common_commands_spec.js
Outdated
Show resolved
Hide resolved
e2e/cypress/integration/integrations/builtin_commands/common_commands_spec.js
Show resolved
Hide resolved
Co-authored-by: Saturnino Abril <[email protected]>
|
Thanks for the review @saturninoabril. PTAL |
saturninoabril
approved these changes
Oct 8, 2020
e2e/cypress/integration/integrations/builtin_commands/common_commands_spec.js
Show resolved
Hide resolved
|
Swapping in @srkgupta as a second reviewers to even out the number of open reviews. I hope you are fine with this @DHaussermann |
|
/update-branch |
srkgupta
suggested changes
Oct 12, 2020
There was a problem hiding this comment.
Hi @hanzei
The tests looks great to me and are all working fine. Just one small change requested in both the testcase files:
Can you remove the @prod tag from both the testcase files as you have added new testcases to the existing file. These tests will be executed for 5 days and if it consistently passes, then QA team will promote them to @prod.
|
@srkgupta Sure, done. |
jfrerich
pushed a commit
that referenced
this pull request
Oct 23, 2020
…ands (10 test cases) (#6638) * Cypress/E2E: Automate backlogs - Integrations > Slash Commands (10 test cases) * Add test for /code with no text * Apply suggestions from code review Co-authored-by: Saturnino Abril <[email protected]> * Fix style * Remove prod stage Co-authored-by: Saturnino Abril <[email protected]> Co-authored-by: Mattermod <[email protected]>
calebroseland
pushed a commit
that referenced
this pull request
Oct 27, 2020
…ands (10 test cases) (#6638) * Cypress/E2E: Automate backlogs - Integrations > Slash Commands (10 test cases) * Add test for /code with no text * Apply suggestions from code review Co-authored-by: Saturnino Abril <[email protected]> * Fix style * Remove prod stage Co-authored-by: Saturnino Abril <[email protected]> Co-authored-by: Mattermod <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I did modify
loginAndVisitChannelto support options in case some other test case want to use it too.Ticket Link
https://mattermost.atlassian.net/browse/MM-28257