This repository has been archived by the owner on Mar 13, 2024. It is now read-only.
PLT-8528 removed check that was prevent submit if names were unchanged #660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@stephenkiers You have some eslint errors. |
hmhealey
suggested changes
Jan 26, 2018
| @@ -189,7 +187,7 @@ export class RenameChannelModal extends React.PureComponent { | |||
|
|
|||
| this.setState(state); | |||
|
|
|||
| if (state.invalid || (oldName === channel.name && oldDisplayName === channel.display_name)) { | |||
There was a problem hiding this comment.
If the names didn't change, can we exit early without even sending a request to the server?
There was a problem hiding this comment.
Great point. Fixed
crspeller
approved these changes
Feb 2, 2018
hmhealey
approved these changes
Feb 5, 2018
hmhealey
pushed a commit
that referenced
this pull request
Aug 28, 2020
- No additions or deletions, just a few homepage and copyright year updates - Normalizing to the automation-friendly format so future diffs will be smaller.
hmhealey
pushed a commit
that referenced
this pull request
Mar 17, 2021
- No additions or deletions, just a few homepage and copyright year updates - Normalizing to the automation-friendly format so future diffs will be smaller.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hitting save on the change channel name header without changing the name did nothing.
There was a specific check preventing it from saving. I removed that check, and it now does as expected
Ticket Link
https://mattermost.atlassian.net/browse/PLT-8528
Checklist
make check-styleto check for style errors (required for all pull requests)