MM-27909: Add shared channel permission

[agnivade]

We add the UI element to show the shared channel permission.
It is gated by the toggling of the config setting EnableSharedChannels.

For now, we just test with snapshots. Since it's not fully clear yet how the permissions and roles will look finally. Later we need a Cypress test to validate all of this. Ticket filed: https://mattermost.atlassian.net/browse/MM-29047

https://mattermost.atlassian.net/browse/MM-27909

Summary

Ticket Link

Related Pull Requests

• Has server changes (MM-27909: Add manage_shared_channels permission mattermost#15601)
• Has redux changes (MM-27909: Add shared channel permission mattermost-redux#1246)
• Has mobile changes (please link here)

Screenshots

[agnivade]

Gentle ping @mkraft and @wiersgallak

[wiggin77]

LGTM 👍

[srkgupta]

Hi @agnivade

I am testing this PR along with its dependent PRs and I am seeing the following issues.

1. The Managed Shared Channels permission is only displayed for All Members and Sysadmins. Its not displayed for Channel Admins and Team Admins as shown in this screenshot.

2. Manage Shared Channel permission is not displayed in Team Override Schemes. It is expected to be displayed even in this screen.

3. Manage Shared Channel permission is displayed on an E10 instance as well. I believe Shared Channels is only a E20 feature and hence this permission should only be displayed on E20 instance.

[agnivade]

Hi @srkgupta

1. It's because it's a system-scoped permission.
2. Same as above.
3. The E10/E20 thing needs to be done from the server side. The ticket is https://mattermost.atlassian.net/browse/MM-29027. I have updated the ticket to note that the permission in the UI should be shown appropriately.

[srkgupta]

Hi @agnivade,
Regarding 1 & 2, can you please help me understand whats a system scoped permission is and why it needs to be only displayed for All Members and Sysadmins and not for Channel and Team Admins.

Regarding 3, we generally test all the dependent PRs together and comment on one of the PRs. In this case, this PR was tested along with the server PR mattermost/mattermost#15601 and it was found that the new permission is also displayed on E10 instance, which is wrong and should be fixed.

[agnivade]

From what I understand, a system scoped permission is for the entire system and not tied to a channel or a team. You will see other various system scoped permission behave in the same way. They don't appear for channel or team admins because it's not at that level. For more information you can follow the conversation that happened on mattermost/mattermost#15601. We agreed to change the scope from channel to system.

On E20, we are still in the process of creating the basic scaffolding needed for this feature. So things may not be in the perfect order. If it's required to be done as part of this PR, then we can park this PR until that ticket is merged, and then I can incorporate the changes after that.

[srkgupta]

Thanks @agnivade. I have updated the ticket MM-27909 based on the issues 1 & 2 mentioned above. Regarding issue 3, as long as it is being tracked and will be handled in future PRs, it's fine. Tested the PR along with its dependent PRs and permission is showing up and working fine on System Console. Approving the PR.