Skip to content
This repository has been archived by the owner on Mar 13, 2024. It is now read-only.

[MM-28644] Close RHS when the Next Steps view is mounted #6480

Merged
merged 3 commits into from
Sep 17, 2020

Conversation

devinbinnie
Copy link
Member

Summary

If you return to the Getting Started/Tips and Next Steps view while the RHS is open, the RHS displays over top.
This PR closes the RHS when the view is mounted so that there's nothing over top of the view.

Ticket Link

https://mattermost.atlassian.net/browse/MM-28644

@devinbinnie devinbinnie added 2: Dev Review Requires review by a core commiter 3: QA Review Requires review by a QA tester labels Sep 17, 2020
Copy link
Contributor

@alifarooq0 alifarooq0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oo, looks like this has a few conflicts. Otherwise LGTM 👍

@stevemudie stevemudie added the Setup Cloud Test Server Setup a test server using Mattermost Cloud label Sep 17, 2020
@devinbinnie devinbinnie removed the 2: Dev Review Requires review by a core commiter label Sep 17, 2020
Copy link
Contributor

@stevemudie stevemudie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stevemudie stevemudie added QA Review Done and removed 3: QA Review Requires review by a QA tester Setup Cloud Test Server Setup a test server using Mattermost Cloud labels Sep 17, 2020
@mm-cloud-bot
Copy link

Test server destroyed

@devinbinnie devinbinnie added the 4: Reviews Complete All reviewers have approved the pull request label Sep 17, 2020
@devinbinnie devinbinnie merged commit f2bfb78 into mattermost:master Sep 17, 2020
@amyblais amyblais added Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation labels Sep 17, 2020
jfrerich pushed a commit that referenced this pull request Oct 23, 2020
* [MM-28644] Close RHS when the Next Steps view is mounted

* Test fix
calebroseland pushed a commit that referenced this pull request Oct 27, 2020
* [MM-28644] Close RHS when the Next Steps view is mounted

* Test fix
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
4: Reviews Complete All reviewers have approved the pull request Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation QA Review Done
Projects
None yet
6 participants