Skip to content
This repository has been archived by the owner on Mar 13, 2024. It is now read-only.

Cypress/E2E: Move cy.apiCreateBot and fix MM-T251 & MM-T252 #6471

Merged
merged 2 commits into from
Sep 18, 2020
Merged

Cypress/E2E: Move cy.apiCreateBot and fix MM-T251 & MM-T252 #6471

merged 2 commits into from
Sep 18, 2020

Conversation

saturninoabril
Copy link
Member

@saturninoabril saturninoabril commented Sep 17, 2020 •
edited
Loading

Summary

  • Move cy.apiCreateBot
  • While testing change due to movement of cy.apiCreateBot, I came across to fix failing on MM-T252. I should make a separate PR for this change but those are connected in some ways.
  • add fix for MM-T251

@saturninoabril saturninoabril added the 3: QA Review Requires review by a QA tester label Sep 17, 2020
@saturninoabril saturninoabril changed the title Cypress/E2E: Move cy.apiCreateBot and fix MM-T252 Cypress/E2E: Move cy.apiCreateBot and fix MM-T251 & MM-T252 Sep 17, 2020
srkgupta
srkgupta approved these changes Sep 17, 2020
View reviewed changes
Copy link
Contributor

@srkgupta srkgupta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and all changed tests passed. Changes LGTM

@saturninoabril saturninoabril added this to the v5.28 milestone Sep 17, 2020
@saturninoabril saturninoabril added the CherryPick/Approved Meant for the quality or patch release tracked in the milestone label Sep 17, 2020
prapti
prapti approved these changes Sep 18, 2020
View reviewed changes
Copy link
Contributor

@prapti prapti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Tests passed.

@prapti prapti added 4: Reviews Complete All reviewers have approved the pull request and removed 3: QA Review Requires review by a QA tester labels Sep 18, 2020
@prapti prapti merged commit 6d5f652 into mattermost:master Sep 18, 2020
@mattermod
Copy link
Contributor

Cherry pick is scheduled.

mattermost-build pushed a commit to mattermost-build/mattermost-webapp that referenced this pull request Sep 18, 2020
@saturninoabril @mattermost-build
Cypress/E2E: Move cy.apiCreateBot and fix MM-T251 & MM-T252 (mattermo…
c9e7abc 
…st#6471)

* move apiCreateBot and fix MM-T252

* fix MM-T251

(cherry picked from commit 6d5f652)
@mattermost-build mattermost-build mentioned this pull request Sep 18, 2020
Merged
@mattermod mattermod added CherryPick/Done Successfully cherry-picked to the quality or patch release tracked in the milestone and removed CherryPick/Approved Meant for the quality or patch release tracked in the milestone labels Sep 18, 2020
mattermod pushed a commit that referenced this pull request Sep 18, 2020
@mattermost-build
Cypress/E2E: Move cy.apiCreateBot and fix MM-T251 & MM-T252 (#6471) (#…
37936c5 
…6488)

Automatic Merge
@saturninoabril saturninoabril deleted the cypress-move-bot-api branch September 18, 2020 05:48
@amyblais amyblais added Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation labels Sep 18, 2020
jfrerich pushed a commit that referenced this pull request Oct 23, 2020
@saturninoabril @jfrerich
Cypress/E2E: Move cy.apiCreateBot and fix MM-T251 & MM-T252 (#6471)
63eecaf 
* move apiCreateBot and fix MM-T252

* fix MM-T251
calebroseland pushed a commit that referenced this pull request Oct 27, 2020
@saturninoabril @calebroseland
Cypress/E2E: Move cy.apiCreateBot and fix MM-T251 & MM-T252 (#6471)
9a2cd1b 
* move apiCreateBot and fix MM-T252

* fix MM-T251
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@prapti prapti prapti approved these changes

@srkgupta srkgupta srkgupta approved these changes

Assignees
No one assigned
Labels
4: Reviews Complete All reviewers have approved the pull request Changelog/Not Needed Does not require a changelog entry CherryPick/Done Successfully cherry-picked to the quality or patch release tracked in the milestone Docs/Not Needed Does not require documentation
Projects
None yet
Milestone
v5.28.0
5 participants
@saturninoabril @mattermod @prapti @srkgupta @amyblais