Skip to content
This repository has been archived by the owner on Mar 13, 2024. It is now read-only.

MM-28209: fix dual scrollbars in channel switcher #6453

Merged
merged 1 commit into from
Sep 16, 2020
Merged

MM-28209: fix dual scrollbars in channel switcher #6453

merged 1 commit into from
Sep 16, 2020

Conversation

calebroseland
Copy link
Member

Summary

  • MM-28209 Sync fixed-height content to match max dynamic-hight content to prevent dual scrollbars.

Screenshots

Screen Shot 2020-09-15 at 11 22 47

@calebroseland calebroseland added 2: Dev Review Requires review by a core commiter 3: QA Review Requires review by a QA tester labels Sep 15, 2020
@calebroseland calebroseland added this to the v5.28 milestone Sep 15, 2020
@calebroseland calebroseland added the Setup Cloud Test Server Setup a test server using Mattermost Cloud label Sep 15, 2020
ogi-m
ogi-m approved these changes Sep 16, 2020
View reviewed changes
Copy link

@ogi-m ogi-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

  • no second scrollbar
  • consistent modal height

@ogi-m ogi-m removed the 3: QA Review Requires review by a QA tester label Sep 16, 2020
@calebroseland calebroseland added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core commiter Setup Cloud Test Server Setup a test server using Mattermost Cloud labels Sep 16, 2020
@mm-cloud-bot
Copy link

Test server destroyed

@calebroseland calebroseland merged commit 5f77136 into master Sep 16, 2020
@calebroseland calebroseland deleted the MM-28209 branch September 16, 2020 13:49
@amyblais amyblais added Changelog/Done Required changelog entry has been written Docs/Not Needed Does not require documentation labels Sep 18, 2020
@ogi-m ogi-m added the Tests/Not Needed Does not require new release tests label Oct 14, 2020
jfrerich pushed a commit that referenced this pull request Oct 23, 2020
@calebroseland @jfrerich
sync height (#6453)
210a221
calebroseland added a commit that referenced this pull request Oct 27, 2020
@calebroseland
sync height (#6453)
a86e6b4
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@asaadmahmood asaadmahmood asaadmahmood approved these changes

@ogi-m ogi-m ogi-m approved these changes

@nevyangelova nevyangelova nevyangelova approved these changes

Assignees
No one assigned
Labels
4: Reviews Complete All reviewers have approved the pull request Changelog/Done Required changelog entry has been written Docs/Not Needed Does not require documentation Tests/Not Needed Does not require new release tests
Projects
None yet
Milestone
v5.28.0
Development

Successfully merging this pull request may close these issues.
6 participants
@calebroseland @mm-cloud-bot @asaadmahmood @ogi-m @nevyangelova @amyblais