Skip to content
This repository has been archived by the owner on Mar 13, 2024. It is now read-only.

[MM-27814] cypress test for T553 #6435

Merged
merged 2 commits into from
Sep 17, 2020
Merged

[MM-27814] cypress test for T553 #6435

merged 2 commits into from
Sep 17, 2020

Conversation

ashishbhate
Copy link
Contributor

Summary

  • Cypress test for T553: Reply Notifications – that I start or participate in – start the thread
  • Clarify test name of similar test

Ticket Link

@ashishbhate ashishbhate added 2: Dev Review Requires review by a core commiter 3: QA Review Requires review by a QA tester labels Sep 14, 2020
srkgupta
srkgupta approved these changes Sep 15, 2020
View reviewed changes
Copy link
Contributor

@srkgupta srkgupta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ashishbhate. Tested and working fine. The test LGTM. Approving the PR.

@srkgupta srkgupta removed the 2: Dev Review Requires review by a core commiter label Sep 15, 2020
ogi-m
ogi-m approved these changes Sep 16, 2020
View reviewed changes
Copy link

@ogi-m ogi-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@ogi-m ogi-m added 4: Reviews Complete All reviewers have approved the pull request and removed 3: QA Review Requires review by a QA tester labels Sep 16, 2020
@ashishbhate ashishbhate merged commit 9cc3923 into master Sep 17, 2020
@ashishbhate ashishbhate deleted the MM-27814-T553 branch September 17, 2020 06:03
@amyblais amyblais added Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation labels Sep 17, 2020
jfrerich pushed a commit that referenced this pull request Oct 23, 2020
@ashishbhate @jfrerich
[MM-27814] cypress test for T553 (#6435)
a77a7e2 
Summary
- Cypress test for T553: Reply Notifications – that I start or participate in – start the thread
- Clarify test name of similar test

Ticket Link
- https://mattermost.atlassian.net/browse/MM-27814
calebroseland pushed a commit that referenced this pull request Oct 27, 2020
@ashishbhate @calebroseland
[MM-27814] cypress test for T553 (#6435)
f7a2348 
Summary
- Cypress test for T553: Reply Notifications – that I start or participate in – start the thread
- Clarify test name of similar test

Ticket Link
- https://mattermost.atlassian.net/browse/MM-27814
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@reflog reflog reflog approved these changes

@srkgupta srkgupta srkgupta approved these changes

@ogi-m ogi-m ogi-m approved these changes

Assignees
No one assigned
Labels
4: Reviews Complete All reviewers have approved the pull request Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation
Projects
None yet
Milestone
No milestone
5 participants
@ashishbhate @reflog @srkgupta @ogi-m @amyblais