Convert user_access_token_section to TypeScript

[hiendinhngoc]

Summary

Migrate 'components/user_settings/security/user_access_token_section' module and associated tests to TypeScript

Ticket Link

Fixes mattermost/mattermost#13693
JIRA: https://mattermost.atlassian.net/browse/MM-20548

[hiendinhngoc]

I got an error at line 50 in index.ts file:
userAccessTokens: state.entities.users.myUserAccessTokens

error: Property 'myUserAccessTokens' does not exist on type 'UsersState'.
I already checked UsersState, it really doesn't have myUserAccessTokens property.

[devinbinnie]

I got an error at line 50 in index.ts file:
userAccessTokens: state.entities.users.myUserAccessTokens

error: Property 'myUserAccessTokens' does not exist on type 'UsersState'.
I already checked UsersState, it really doesn't have myUserAccessTokens property.

Thanks for the catch! I'll make a change to redux and get that fixed.

[devinbinnie]

@hiendinhngoc The fix is in, you'll just need to update the mattermost-redux package to this commit and everything should work nicely: 1838b6c20c51d9f2a8c9899c91417672dced87f0

[hiendinhngoc]

@hiendinhngoc The fix is in, you'll just need to update the mattermost-redux package to this commit and everything should work nicely: 1838b6c20c51d9f2a8c9899c91417672dced87f0

@devinbinnie thank you, I updated in my side by entering the version to package.json file, then npm install. After that, the error came out and type-check was passed from my local. However, CI shows the error with type-check. Is there any step that I missed or sth wrong here?

[devinbinnie]

@hiendinhngoc The fix is in, you'll just need to update the mattermost-redux package to this commit and everything should work nicely: 1838b6c20c51d9f2a8c9899c91417672dced87f0

@devinbinnie thank you, I updated in my side by entering the version to package.json file, then npm install. After that, the error came out and type-check was passed from my local. However, CI shows the error with type-check. Is there any step that I missed or sth wrong here?

@hiendinhngoc CircleCI uses the copy of package-lock.json in the repo in order to fetch its packages, so you'll need to change that as well. Sorry for the inconvience.

[hiendinhngoc]

@devinbinnie It seems an update for mattermost-redux at previous commit which caused type check error when I changed to 1838b6c20c51d9f2a8c9899c91417672dced87f0

[devinbinnie]

@devinbinnie It seems an update for mattermost-redux at previous commit which caused type check error when I changed to 1838b6c20c51d9f2a8c9899c91417672dced87f0

@hiendinhngoc I guess you'll have to update the files to the latest commit then, see here: mattermost/mattermost-redux@6fdb466

[mattermod]

This PR has been automatically labelled "stale" because it hasn't had recent activity.
A core team member will check in on the status of the PR to help with questions.
Thank you for your contribution!

/cc @jasonblais @jfrerich

[jasonblais]

Hi @hiendinhngoc, did you have questions on how to update the files to the latest commit: mattermost/mattermost-redux@6fdb466

If any, let us know! Happy to help :)

[devinbinnie]

Looks good overall @hiendinhngoc, thanks for the contribution!
Just had a couple comments.

[devinbinnie]

/update-branch

[devinbinnie]

LGTM! Thanks @hiendinhngoc!

[hmhealey]

Thanks for the work on this, @hiendinhngoc. I have a couple suggestions for things to change, but they're just tightening up the type definitions slightly.

[hmhealey]

Thanks! This is good for QA review then

[jgilliam17]

Thank you @hiendinhngoc
Tested, looks good to merge.

• Verified Personal Access Tokens section in Account Settings>Security. Able to create, deactivate, delete - as expected.
  @devinbinnie Can you please help merge? Thanks. 🙂

[mm-cloud-bot]

Test server destroyed