Skip to content
This repository has been archived by the owner on Mar 13, 2024. It is now read-only.

Cypress/E2E: Add TM4J IDs #6397

Merged
merged 2 commits into from
Sep 9, 2020
Merged

Cypress/E2E: Add TM4J IDs #6397

merged 2 commits into from
Sep 9, 2020

Conversation

saturninoabril
Copy link
Member

Summary

Add TM4J IDs to already automated test cases

@saturninoabril saturninoabril added the 3: QA Review Requires review by a QA tester label Sep 8, 2020
srkgupta
srkgupta approved these changes Sep 8, 2020
View reviewed changes
Copy link
Contributor

@srkgupta srkgupta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

prapti
prapti approved these changes Sep 9, 2020
View reviewed changes
Copy link
Contributor

@prapti prapti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, but requesting very minor changes to match the text in TM4J test case titles.
Thank you Saturn!

e2e/cypress/integration/system_console/revoke_all_sessions_spec.js Outdated Show resolved Hide resolved
e2e/cypress/integration/team_settings/remove_team_icon_spec.js Outdated Show resolved Hide resolved
e2e/cypress/integration/team_settings/teams_spec.js Outdated Show resolved Hide resolved
@prapti prapti added 4: Reviews Complete All reviewers have approved the pull request Awaiting Submitter Action Blocked on the author and removed 3: QA Review Requires review by a QA tester labels Sep 9, 2020
@saturninoabril @prapti
Apply suggestions from code review
62395fa 
per comments

Co-authored-by: Prapti <[email protected]>
@saturninoabril
Copy link
Member Author

Thanks @prapti! Applied all suggestions.

@saturninoabril saturninoabril added AutoMerge used by Mattermod to merge PR automatically and removed Awaiting Submitter Action Blocked on the author labels Sep 9, 2020
@mattermod
Copy link
Contributor

Will try to auto merge this PR once all tests and checks are passing. This might take up to an hour.

@saturninoabril saturninoabril merged commit a6f836a into mattermost:master Sep 9, 2020
@mattermod mattermod removed the AutoMerge used by Mattermod to merge PR automatically label Sep 9, 2020
@saturninoabril saturninoabril deleted the add-tm4j-id branch September 9, 2020 18:08
@amyblais amyblais added Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation labels Sep 9, 2020
jfrerich pushed a commit that referenced this pull request Oct 23, 2020
@saturninoabril @prapti @jfrerich
Cypress/E2E: Add TM4J IDs (#6397)
e25c222 
* add TM4J IDs

* Apply suggestions from code review

per comments

Co-authored-by: Prapti <[email protected]>

Co-authored-by: Prapti <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@prapti prapti prapti approved these changes

@srkgupta srkgupta srkgupta approved these changes

Assignees
No one assigned
Labels
4: Reviews Complete All reviewers have approved the pull request Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation
Projects
None yet
Milestone
No milestone
5 participants
@saturninoabril @mattermod @prapti @srkgupta @amyblais