This repository has been archived by the owner on Mar 13, 2024. It is now read-only.
ABC-79: populate channel autocomplete results with local data immediately #639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grundleborg
approved these changes
Jan 22, 2018
Perhaps something similar to the channel switcher
I'll think about this more and perhaps bring up in UX channel, but I'm a little worried about that. |
|
jwilander
approved these changes
Jan 22, 2018
|
@jasonblais Added the loading indicator. I'd say that's definitely an improvement. Still not sure about the jumpiness though. Seems fine to me and I confirmed that focus is preserved when server-provided results are added. |
|
Functionally it works. Posted in the UX design channel and asked people to test + share feedback about the jumpiness https://pre-release.mattermost.com/core/pl/3jzb3ccs4f81xfdyraurodbz7r |
|
@ccbrown Got initial approval for UX, just getting Shift's feedback as well. |
|
@ccbrown Just needs a rebase and this is good to merge. |
hmhealey
pushed a commit
that referenced
this pull request
Aug 28, 2020
* Fix package.json problems - remove whitespace from license field - correctly link to the github repo * Add link to issue tracker
hmhealey
pushed a commit
that referenced
this pull request
Mar 17, 2021
* Fix package.json problems - remove whitespace from license field - correctly link to the github repo * Add link to issue tracker
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This populates channel autocomplete results with local data immediately. When more channels are returned from the server, they will be added to the results. In addition to improving usability on large servers, this ensures that joined channels are always shown in the autocomplete results.
Discussion: https://pre-release.mattermost.com/core/pl/3nzompitxpfi8do54r1xtb7ooa
Ticket Link
https://mattermost.atlassian.net/browse/ABC-79
Checklist
make check-styleto check for style errors (required for all pull requests)