Skip to content
This repository has been archived by the owner on Mar 13, 2024. It is now read-only.

Cypress/E2E: Fix "app.role.save.invalid_role.app_error" when patching roles #6387

Merged
merged 2 commits into from
Sep 7, 2020
Merged

Cypress/E2E: Fix "app.role.save.invalid_role.app_error" when patching roles #6387

merged 2 commits into from
Sep 7, 2020

Conversation

saturninoabril
Copy link
Member

Summary

  • Fix "app.role.save.invalid_role.app_error" when patching roles by updating default roles
  • Move api commands to its own /api/role

@saturninoabril saturninoabril added 2: Dev Review Requires review by a core commiter 3: QA Review Requires review by a QA tester labels Sep 6, 2020
srkgupta
srkgupta approved these changes Sep 7, 2020
View reviewed changes
Copy link
Contributor

@srkgupta srkgupta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran the tests related to reset roles and they worked fine. The changes LGTM. Thanks @saturninoabril

@srkgupta srkgupta added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core commiter 3: QA Review Requires review by a QA tester labels Sep 7, 2020
@srkgupta
Copy link
Contributor

srkgupta commented Sep 7, 2020

Hi @saturninoabril,
I am not approving the PR yet, as I still see the changes suggested by @fmunshi open. Please commit them and feel free to merge the PR.

@saturninoabril
Copy link
Member Author

Thanks @srkgupta! Yup, I'll apply the comment but will wait for the new master docker, run tests against it and sort out final fix on master.

@saturninoabril
Copy link
Member Author

@fmunshi Now added and looks good. Thanks for checking!

@saturninoabril saturninoabril added 2: Dev Review Requires review by a core commiter and removed 4: Reviews Complete All reviewers have approved the pull request labels Sep 7, 2020
@fmunshi fmunshi added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core commiter labels Sep 7, 2020
@saturninoabril saturninoabril merged commit 52df410 into mattermost:master Sep 7, 2020
@saturninoabril saturninoabril deleted the fix-roles branch September 7, 2020 15:13
@amyblais amyblais added Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation labels Sep 7, 2020
jfrerich pushed a commit that referenced this pull request Oct 23, 2020
@saturninoabril @jfrerich
Cypress/E2E: Fix "app.role.save.invalid_role.app_error" when patching…
5c588f4 
… roles (#6387)

* fix "app.role.save.invalid_role.app_error" when patching roles

* per comment
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@srkgupta srkgupta srkgupta approved these changes

@fmunshi fmunshi fmunshi approved these changes

Assignees
No one assigned
Labels
4: Reviews Complete All reviewers have approved the pull request Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation
Projects
None yet
Milestone
No milestone
4 participants
@saturninoabril @srkgupta @fmunshi @amyblais