Skip to content
This repository has been archived by the owner on Mar 13, 2024. It is now read-only.

Updating compass icons #6370

Merged
merged 1 commit into from
Sep 11, 2020
Merged

Updating compass icons #6370

merged 1 commit into from
Sep 11, 2020

Conversation

asaadmahmood
Copy link
Contributor

@asaadmahmood asaadmahmood commented Sep 3, 2020 •
edited
Loading

Summary

Updating compass icons

Ticket:

https://mattermost.atlassian.net/browse/MM-28200

@hmhealey
Copy link
Member

hmhealey commented Sep 3, 2020

Is there a ticket attached to this or something we can refer to for what changed?

@hmhealey hmhealey added 2: Dev Review Requires review by a core commiter 3: QA Review Requires review by a QA tester labels Sep 3, 2020
@devinbinnie
Copy link
Member

@hmhealey @asaadmahmood You can use this, as I needed the credit card icon added:
https://mattermost.atlassian.net/browse/MM-28200

@asaadmahmood
Copy link
Contributor Author

For QA, just have a quick scan and see if the icons in the app (sidebar, autocomplete etc) appear the same on this PR as in daily.

@srkgupta srkgupta added the Setup Cloud Test Server Setup a test server using Mattermost Cloud label Sep 11, 2020
srkgupta
srkgupta approved these changes Sep 11, 2020
View reviewed changes
Copy link
Contributor

@srkgupta srkgupta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did some sanity test on the webapp and the icons looked fine. Approving the PR.

@srkgupta srkgupta added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core commiter 3: QA Review Requires review by a QA tester Setup Cloud Test Server Setup a test server using Mattermost Cloud labels Sep 11, 2020
@mm-cloud-bot
Copy link

Test server destroyed

@asaadmahmood asaadmahmood merged commit 88c25c7 into mattermost:master Sep 11, 2020
@asaadmahmood asaadmahmood deleted the compass-icons branch September 11, 2020 11:39
@amyblais amyblais added Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation labels Sep 11, 2020
jfrerich pushed a commit that referenced this pull request Oct 23, 2020
@asaadmahmood @jfrerich
Updating compass icons (#6370)
0d37137
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@srkgupta srkgupta srkgupta approved these changes

@hmhealey hmhealey hmhealey approved these changes

@devinbinnie devinbinnie devinbinnie approved these changes

Assignees
No one assigned
Labels
4: Reviews Complete All reviewers have approved the pull request Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation
Projects
None yet
Milestone
No milestone
6 participants
@asaadmahmood @hmhealey @devinbinnie @mm-cloud-bot @srkgupta @amyblais