Skip to content
This repository has been archived by the owner on Mar 13, 2024. It is now read-only.

[MM-27954] Fix JS error on sys console groups page #6354

Merged
merged 3 commits into from
Sep 7, 2020
Merged

[MM-27954] Fix JS error on sys console groups page #6354

merged 3 commits into from
Sep 7, 2020

Conversation

fmunshi
Copy link
Contributor

@fmunshi fmunshi commented Sep 1, 2020

Summary

  • Fixes an issue where this.setState undefined error shows up, prevent this error by making closeFilters an arrow function

Ticket Link

image

@fmunshi fmunshi added 2: Dev Review Requires review by a core commiter 3: QA Review Requires review by a QA tester labels Sep 1, 2020
sbishel
sbishel approved these changes Sep 3, 2020
View reviewed changes
components/admin_console/group_settings/group_settings.jsx
isDisabled: PropTypes.oneOfType([
PropTypes.func,
PropTypes.bool,
]),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this related or something separate?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was a separate issue - isDisabled can be both a function or a bool... there was a console error that showed up on this page because of that

@calebroseland calebroseland removed the 2: Dev Review Requires review by a core commiter label Sep 3, 2020
@fmunshi fmunshi added this to the v5.28 milestone Sep 3, 2020
srkgupta
srkgupta approved these changes Sep 7, 2020
View reviewed changes
Copy link
Contributor

@srkgupta srkgupta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and the issue is fixed now and is working fine and there are no JS errors thrown. Approving the PR

@srkgupta srkgupta added 4: Reviews Complete All reviewers have approved the pull request and removed 3: QA Review Requires review by a QA tester labels Sep 7, 2020
@srkgupta
Copy link
Contributor

srkgupta commented Sep 7, 2020

/update-branch

@fmunshi fmunshi merged commit 3698b33 into master Sep 7, 2020
@fmunshi fmunshi deleted the MM-27954 branch September 7, 2020 20:09
@amyblais amyblais added Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation labels Sep 8, 2020
jfrerich pushed a commit that referenced this pull request Oct 23, 2020
@fmunshi @mattermod @jfrerich
Fix JS error on sys console groups page (#6354)
782f030 
Co-authored-by: Mattermod <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@srkgupta srkgupta srkgupta approved these changes

@calebroseland calebroseland calebroseland approved these changes

@sbishel sbishel sbishel approved these changes

Assignees
No one assigned
Labels
4: Reviews Complete All reviewers have approved the pull request Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation
Projects
None yet
Milestone
v5.28.0
Development

Successfully merging this pull request may close these issues.
6 participants
@fmunshi @srkgupta @calebroseland @sbishel @amyblais @mattermod