[Weblate] Remove empty/unchanged translation strings. Add Bulgarian language. Add general translation updates. #6349

metanerd · 2020-09-01T09:23:52Z

Summary

Remove empty/unchanged translation strings. Add Bulgarian language. Add general translation updates.

Ticket Link

Related Pull Requests

Has server changes (please link here)
Has redux changes (please link here)
Has mobile changes (please link here)

Screenshots

Updated by "Cleanup translation files" hook in Weblate. Translation: mattermost-languages-shipped/mattermost-webapp_master Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/

Currently translated at 95.3% (3894 of 4084 strings) Translation: mattermost-languages-shipped/mattermost-webapp_master Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/de/ Added translation using Weblate (Bulgarian) Translated using Weblate (Ukrainian) Currently translated at 77.1% (3148 of 4080 strings) Translation: mattermost-languages-shipped/mattermost-webapp_master Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/uk/ Translated using Weblate (Polish) Currently translated at 90.9% (3711 of 4080 strings) Translation: mattermost-languages-shipped/mattermost-webapp_master Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/pl/ Translated using Weblate (French) Currently translated at 93.5% (3816 of 4080 strings) Translation: mattermost-languages-shipped/mattermost-webapp_master Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/fr/ Translated using Weblate (Ukrainian) Currently translated at 84.2% (3438 of 4080 strings) Translation: mattermost-languages-shipped/mattermost-webapp_master Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/uk/ Translated using Weblate (Ukrainian) Currently translated at 86.3% (3524 of 4080 strings) Translation: mattermost-languages-shipped/mattermost-webapp_master Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/uk/ Translated using Weblate (Ukrainian) Currently translated at 91.9% (3690 of 4011 strings) Translation: mattermost-languages-shipped/mattermost-webapp_master Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/uk/ Translated using Weblate (French) Currently translated at 97.6% (3917 of 4011 strings) Translation: mattermost-languages-shipped/mattermost-webapp_master Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/fr/ Translated using Weblate (German) Currently translated at 97.0% (3894 of 4011 strings) Translation: mattermost-languages-shipped/mattermost-webapp_master Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/de/

Currently translated at 99.8% (4003 of 4011 strings) Translation: mattermost-languages-shipped/mattermost-webapp_master Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/ja/

Currently translated at 0.0% (0 of 4084 strings) Translation: mattermost-languages-shipped/mattermost-webapp_master Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/bg/

Updated by "Cleanup translation files" hook in Weblate. Translation: mattermost-languages-shipped/mattermost-webapp_master Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/

metanerd · 2020-09-01T09:46:12Z

/update-branch

enahum · 2020-09-01T12:32:39Z

i18n/i18n.jsx

+ bg: {
+ value: 'bg',
+ name: 'България',
+ order: 0,


please update the order of the other languages

enahum · 2020-09-01T12:35:55Z

This one needs a QA review

…ermost-webapp into weblate-fix-empty-master

jasonblais

1 - Bulgarian language addition looks good, except please also add test for it at: https://github.com/mattermost/mattermost-webapp/blob/master/components/admin_console/__snapshots__/schema_admin_settings.test.jsx.snap

2 - Question: what does "general translation updates" refer to?

3 - Two other comments below

jasonblais · 2020-09-01T12:55:44Z

i18n/de.json

@@ -824,12 +824,8 @@
 "admin.permissions.permission.manage_oauth.name": "OAuth-2.0-Applikationen verwalten",
 "admin.permissions.permission.manage_outgoing_webhooks.description": "Eingehende und ausgehende Webhooks erstellen, bearbeiten und löschen.",
 "admin.permissions.permission.manage_outgoing_webhooks.name": "Ausgehende Webhooks verwalten",
- "admin.permissions.permission.manage_private_channel_members.description": "Mitglieder zu privaten Kanälen hinzufügen und entfernen.",


Are these intentionally removed?

jasonblais · 2020-09-01T12:56:03Z

i18n/de.json

+ "warn_metric_ack_modal.learn_more.link": "Mehr erfahren",
+ "team.button.name_undefined": "Dieses Team hat keinen Namen",
+ "team_import_tab.importHelpExportInstructions": "Slack > Administration > Workspace settings > Import/Export Data > Export > Start Export",
+ "channel_modal.displayNameError": "Anzeigename muss mindestens 2 Zeichen lang sein.",


These strings are not in alphabetical order.

@metanerd These strings are still not in alphabetical order - will they be resolved in another PR? If so, I'm fine with that.

metanerd · 2020-09-01T14:11:55Z

1 - Bulgarian language addition looks good, except please also add test for it at: https://github.com/mattermost/mattermost-webapp/blob/master/components/admin_console/__snapshots__/schema_admin_settings.test.jsx.snap

2 - Question: what does "general translation updates" refer to?

3 - Two other comments below

Ah nice, will do!
These are the general updates from this PR: Translations update from Weblate #6347 (I just cannot modify that PR. At least, I don't know how)
Thank you, will fix and enable sorting on weblate side.

nevyangelova

Translations look good although I will say they are quite formal and I thought the language we are keeping is more personal? There are some word shortenings that don't seem necessary IMO. But I won't block the PR just curious :)

Also there's a test failing but I think you only need to update the snapshots.

metanerd · 2020-09-07T22:26:15Z

@jasonblais yes, upcoming PRs will fix the alphabetical order.

jasonblais · 2020-09-07T22:29:45Z

@jgilliam17 this is ready for QA review

jgilliam17

Thank you @metanerd

Verified Bulgarian language has been added in Account Settings>Display>Language
I noticed few issues with capitalization on account settings modal, extra icons on more... links on the old sidebar and the abbreviations and general language improvements Nevy mentioned.
I will create a separate ticket so these translations/changes can be addressed by the contributors.
Can we capitalize the first letter of the language name on the dropdown in this PR?

jgilliam17 · 2020-09-08T19:18:37Z

components/admin_console/__snapshots__/schema_admin_settings.test.jsx.snap

@@ -340,31 +340,36 @@ exports[`components/admin_console/SchemaAdminSettings should match snapshot with
 },
 Object {
 "order": 10,
+ "text": "български (Beta)",


Can you please capitalize, change български to Ƃългарски.
I didn't use the suggestion here as I didn't want to accidentally introduce a different font.

jgilliam17

Thank you @metanerd

Verified Bulgarian language has been added in Account Settings>Display>Language, language title has been capitalized.
Follow up issue added for translation improvement (capitalization missing, abbreviations etc.) https://mattermost.atlassian.net/browse/MM-28522

mm-cloud-bot · 2020-09-10T00:04:00Z

Test server destroyed

# Conflicts: # i18n/uk.json

…anguage. Add general translation updates. (#6349) * Update translation files Updated by "Cleanup translation files" hook in Weblate. Translation: mattermost-languages-shipped/mattermost-webapp_master Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/ * Translated using Weblate (German) Currently translated at 95.3% (3894 of 4084 strings) Translation: mattermost-languages-shipped/mattermost-webapp_master Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/de/ Added translation using Weblate (Bulgarian) Translated using Weblate (Ukrainian) Currently translated at 77.1% (3148 of 4080 strings) Translation: mattermost-languages-shipped/mattermost-webapp_master Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/uk/ Translated using Weblate (Polish) Currently translated at 90.9% (3711 of 4080 strings) Translation: mattermost-languages-shipped/mattermost-webapp_master Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/pl/ Translated using Weblate (French) Currently translated at 93.5% (3816 of 4080 strings) Translation: mattermost-languages-shipped/mattermost-webapp_master Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/fr/ Translated using Weblate (Ukrainian) Currently translated at 84.2% (3438 of 4080 strings) Translation: mattermost-languages-shipped/mattermost-webapp_master Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/uk/ Translated using Weblate (Ukrainian) Currently translated at 86.3% (3524 of 4080 strings) Translation: mattermost-languages-shipped/mattermost-webapp_master Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/uk/ Translated using Weblate (Ukrainian) Currently translated at 91.9% (3690 of 4011 strings) Translation: mattermost-languages-shipped/mattermost-webapp_master Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/uk/ Translated using Weblate (French) Currently translated at 97.6% (3917 of 4011 strings) Translation: mattermost-languages-shipped/mattermost-webapp_master Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/fr/ Translated using Weblate (German) Currently translated at 97.0% (3894 of 4011 strings) Translation: mattermost-languages-shipped/mattermost-webapp_master Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/de/ * Translated using Weblate (Japanese) Currently translated at 99.8% (4003 of 4011 strings) Translation: mattermost-languages-shipped/mattermost-webapp_master Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/ja/ * Translated using Weblate (Bulgarian) Currently translated at 0.0% (0 of 4084 strings) Translation: mattermost-languages-shipped/mattermost-webapp_master Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/bg/ * Update translation files Updated by "Cleanup translation files" hook in Weblate. Translation: mattermost-languages-shipped/mattermost-webapp_master Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/ * Remove empty/unchanged translation strings. Add Bulgarian language. * Reorder language order. * Update snapshot. * Change to uppercase. * Update snapshot * Add rudder keys to node env prod. Co-authored-by: Hosted Weblate <[email protected]> Co-authored-by: Elisabeth Kulzer <[email protected]> Co-authored-by: Anonymous <[email protected]> Co-authored-by: Nikolai Zahariev <[email protected]> Co-authored-by: Mattermod <[email protected]>

ctlaltdieliet

To soon, did'n check all the files

ctlaltdieliet

ok

weblate and others added 10 commits August 31, 2020 18:03

Update translation files

1aa0567

Updated by "Cleanup translation files" hook in Weblate. Translation: mattermost-languages-shipped/mattermost-webapp_master Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/

Translated using Weblate (Japanese)

eb2c97c

Currently translated at 99.8% (4003 of 4011 strings) Translation: mattermost-languages-shipped/mattermost-webapp_master Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/ja/

Translated using Weblate (Bulgarian)

9f3dcea

Currently translated at 0.0% (0 of 4084 strings) Translation: mattermost-languages-shipped/mattermost-webapp_master Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/bg/

Update translation files

3bf1b52

Updated by "Cleanup translation files" hook in Weblate. Translation: mattermost-languages-shipped/mattermost-webapp_master Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/

Merge branch 'origin/master' into Weblate.

eb2d347

Merge branch 'origin/master' into Weblate.

7dc256d

Merge branch 'origin/master' into Weblate.

0736ad2

Merge branch 'origin/master' into Weblate.

e49bea9

Remove empty/unchanged translation strings. Add Bulgarian language.

ec669fd

metanerd requested review from enahum and nevyangelova September 1, 2020 09:23

metanerd mentioned this pull request Sep 1, 2020

Translations update from Weblate #6347

Closed

Merge branch 'master' into weblate-fix-empty-master

0db216f

enahum suggested changes Sep 1, 2020

View reviewed changes

enahum added the 3: QA Review Requires review by a QA tester label Sep 1, 2020

metanerd added 2 commits September 1, 2020 14:42

Reorder language order.

5d5856d

Merge branch 'weblate-fix-empty-master' of github.com:mattermost/matt…

f345013

…ermost-webapp into weblate-fix-empty-master

metanerd requested a review from enahum September 1, 2020 12:44

enahum approved these changes Sep 1, 2020

View reviewed changes

enahum requested a review from jasonblais September 1, 2020 12:47

enahum added 1: PM Review Requires review by a product manager 2: Dev Review Requires review by a core commiter labels Sep 1, 2020

jasonblais suggested changes Sep 1, 2020

View reviewed changes

nevyangelova approved these changes Sep 7, 2020

View reviewed changes

metanerd added 2 commits September 7, 2020 15:44

Merge branch 'master' into weblate-fix-empty-master

e4a05f1

Update snapshot.

b901d78

metanerd requested a review from jasonblais September 7, 2020 14:31

jasonblais added this to the v5.28 milestone Sep 7, 2020

jasonblais approved these changes Sep 7, 2020

View reviewed changes

jasonblais removed 1: PM Review Requires review by a product manager 2: Dev Review Requires review by a core commiter labels Sep 7, 2020

jasonblais requested a review from jgilliam17 September 7, 2020 22:29

jgilliam17 added the Setup Cloud Test Server Setup a test server using Mattermost Cloud label Sep 8, 2020

jgilliam17 suggested changes Sep 8, 2020

View reviewed changes

metanerd added 2 commits September 9, 2020 09:11

Change to uppercase.

a7f1590

Update snapshot

8c087ba

metanerd requested a review from jgilliam17 September 9, 2020 08:33

Add rudder keys to node env prod.

9401830

jgilliam17 approved these changes Sep 10, 2020

View reviewed changes

jgilliam17 added 4: Reviews Complete All reviewers have approved the pull request and removed 3: QA Review Requires review by a QA tester Setup Cloud Test Server Setup a test server using Mattermost Cloud labels Sep 10, 2020

metanerd added 3 commits September 10, 2020 09:07

Merge remote-tracking branch 'origin/master'

e27bd8d

Merge branch 'master' into weblate-fix-empty-master

264ed38

# Conflicts: # i18n/uk.json

Merge branch 'master' into weblate-fix-empty-master

92910f0

metanerd merged commit fbb98a7 into master Sep 10, 2020

metanerd deleted the weblate-fix-empty-master branch September 10, 2020 08:28

amyblais added Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation labels Sep 10, 2020

ctlaltdieliet reviewed Jan 6, 2021

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Weblate] Remove empty/unchanged translation strings. Add Bulgarian language. Add general translation updates. #6349

[Weblate] Remove empty/unchanged translation strings. Add Bulgarian language. Add general translation updates. #6349

metanerd commented Sep 1, 2020

metanerd commented Sep 1, 2020

enahum Sep 1, 2020

enahum commented Sep 1, 2020

jasonblais left a comment

jasonblais Sep 1, 2020

jasonblais Sep 1, 2020

jasonblais Sep 7, 2020

metanerd commented Sep 1, 2020

nevyangelova left a comment •

edited

Loading

metanerd commented Sep 7, 2020

jasonblais commented Sep 7, 2020

jgilliam17 left a comment

jgilliam17 Sep 8, 2020

jgilliam17 left a comment

mm-cloud-bot commented Sep 10, 2020

ctlaltdieliet left a comment •

edited

Loading

ctlaltdieliet left a comment

[Weblate] Remove empty/unchanged translation strings. Add Bulgarian language. Add general translation updates. #6349

[Weblate] Remove empty/unchanged translation strings. Add Bulgarian language. Add general translation updates. #6349

Conversation

metanerd commented Sep 1, 2020

Summary

Ticket Link

Related Pull Requests

Screenshots

metanerd commented Sep 1, 2020

enahum Sep 1, 2020

Choose a reason for hiding this comment

enahum commented Sep 1, 2020

jasonblais left a comment

Choose a reason for hiding this comment

jasonblais Sep 1, 2020

Choose a reason for hiding this comment

jasonblais Sep 1, 2020

Choose a reason for hiding this comment

jasonblais Sep 7, 2020

Choose a reason for hiding this comment

metanerd commented Sep 1, 2020

nevyangelova left a comment • edited Loading

Choose a reason for hiding this comment

metanerd commented Sep 7, 2020

jasonblais commented Sep 7, 2020

jgilliam17 left a comment

Choose a reason for hiding this comment

jgilliam17 Sep 8, 2020

Choose a reason for hiding this comment

jgilliam17 left a comment

Choose a reason for hiding this comment

mm-cloud-bot commented Sep 10, 2020

ctlaltdieliet left a comment • edited Loading

Choose a reason for hiding this comment

ctlaltdieliet left a comment

Choose a reason for hiding this comment

nevyangelova left a comment •

edited

Loading

ctlaltdieliet left a comment •

edited

Loading