This repository has been archived by the owner on Mar 13, 2024. It is now read-only.
MM-T346 Public link related to a deleted post should no longer open the file #6331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
M-ZubairAhmed
changed the title
saturninoabril
added
2: Dev Review
josephbaylon
suggested changes
Aug 31, 2020
There was a problem hiding this comment.
Hi @M-ZubairAhmed , I'm getting a failure when the case is run with other cases in the test file. It runs successfully by itself though. Please check.
|
@josephbaylon Hi, thanks for bringing this up, unfortunately my computer doesnt handle running more than one test simulataneously. Also i see that the problem seems to be in beforeEach. If you can let me know i will gladly be able to fix |
|
@M-ZubairAhmed I tried locally and just needs |
|
@josephbaylon build is failing due to some node error. Can you please check, all other are working fine, is there something i should do from here? |
josephbaylon
approved these changes
Sep 1, 2020
saturninoabril
suggested changes
Sep 2, 2020
saturninoabril
suggested changes
Sep 3, 2020
e2e/cypress/integration/files_and_attachments/upload_files_spec.js
Outdated
Show resolved
Hide resolved
…c.js Co-authored-by: Saturnino Abril <[email protected]>
saturninoabril
approved these changes
Sep 4, 2020
saturninoabril
added
4: Reviews Complete
amyblais
added
Changelog/Not Needed
jfrerich
pushed a commit
that referenced
this pull request
Oct 23, 2020
…he file (#6331) * MM-T346 Public link related to a deleted post should no longer open the file * login as admin * typo * changes * changes * Update e2e/cypress/integration/files_and_attachments/upload_files_spec.js Co-authored-by: Saturnino Abril <[email protected]> * changes 1 Co-authored-by: Saturnino Abril <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR includes an end to end test for verifying the deleted post attachment are indeed deleted when we try to visit their public links
Ticket Link
MM-T346
Related Pull Requests
none
Screenshots
none