Skip to content
This repository has been archived by the owner on Mar 13, 2024. It is now read-only.

MM-T451 Send a DM to someone on no team #6323

Merged
merged 2 commits into from
Sep 3, 2020
Merged

MM-T451 Send a DM to someone on no team #6323

merged 2 commits into from
Sep 3, 2020

Conversation

clarmso
Copy link
Contributor

@clarmso clarmso commented Aug 30, 2020

Summary

A user can send a DM to someone with no team currently.

Ticket Link

https://automation-test-cases.vercel.app/test/MM-T451

Related Pull Requests

  • Has server changes N/A
  • Has redux changes N/A
  • Has mobile changes N/A

Screenshots

Screen Shot 2020-08-29 at 11 41 34 PM

@saturninoabril saturninoabril added 2: Dev Review Requires review by a core commiter 3: QA Review Requires review by a QA tester Hackfest labels Aug 31, 2020
saturninoabril
saturninoabril approved these changes Sep 1, 2020
View reviewed changes
Copy link
Member

@saturninoabril saturninoabril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @clarmso, LGTM. Tested and passed.

@saturninoabril saturninoabril removed the 2: Dev Review Requires review by a core commiter label Sep 1, 2020
@prapti
Copy link
Contributor

prapti commented Sep 3, 2020

/update-branch

prapti
prapti approved these changes Sep 3, 2020
View reviewed changes
Copy link
Contributor

@prapti prapti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is perfect! Thank you so much @clarmso for contributing this test!

@prapti prapti added 4: Reviews Complete All reviewers have approved the pull request and removed 3: QA Review Requires review by a QA tester labels Sep 3, 2020
@prapti prapti merged commit c333a7d into mattermost:master Sep 3, 2020
@clarmso clarmso deleted the MM-T451 branch September 3, 2020 01:02
@amyblais amyblais added Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation labels Sep 6, 2020
jfrerich pushed a commit that referenced this pull request Oct 23, 2020
@clarmso @mattermod @jfrerich
MM-T451 Send a DM to someone on no team (#6323)
6b00b16 
Co-authored-by: Mattermod <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@prapti prapti prapti approved these changes

@saturninoabril saturninoabril saturninoabril approved these changes

Assignees
No one assigned
Labels
4: Reviews Complete All reviewers have approved the pull request Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation Hackfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@clarmso @prapti @saturninoabril @amyblais @mattermod