This repository has been archived by the owner on Mar 13, 2024. It is now read-only.
[MM-27808] e2e/desktop_notifications: add MM-T482 #6307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saturninoabril
suggested changes
Aug 28, 2020
e2e/cypress/integration/notifications/desktop_notifications_spec.js
Outdated
Show resolved
Hide resolved
e2e/cypress/integration/notifications/desktop_notifications_spec.js
Outdated
Show resolved
Hide resolved
Co-authored-by: Saturnino Abril <[email protected]>
saturninoabril
approved these changes
Sep 1, 2020
There was a problem hiding this comment.
Thanks @isacikgoz! Tested and passed. Looks good to me, except for minor comment.
e2e/cypress/integration/notifications/desktop_notifications_spec.js
Outdated
Show resolved
Hide resolved
…ec.js Co-authored-by: Saturnino Abril <[email protected]>
lindy65
approved these changes
Sep 3, 2020
mgdelacroix
approved these changes
Sep 3, 2020
jfrerich
pushed a commit
that referenced
this pull request
Oct 23, 2020
* e2e/desktop_notifications: add MM-T482 * Apply suggestions from code review Co-authored-by: Saturnino Abril <[email protected]> * reflect review comments * Update e2e/cypress/integration/notifications/desktop_notifications_spec.js Co-authored-by: Saturnino Abril <[email protected]> Co-authored-by: Saturnino Abril <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds MM-T482: Desktop Notifications - (at) here not rec'd when logged off.
Ticket Link
https://mattermost.atlassian.net/browse/MM-27808