This repository has been archived by the owner on Mar 13, 2024. It is now read-only.
Write Cypress test: "MM-T1960 Marketplace is available when "Enable Plugins" is true" #6295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mickmister
added
2: Dev Review
prapti
suggested changes
Aug 27, 2020
There was a problem hiding this comment.
I see now what you mean when you said both tests for "Enable Plugins = true" and "Enable Marketplace = true" are exactly the same :) and sorry for not explaining it clearly.
Thank you for fixing some of the earlier tests too!
I hope @josephbaylon answered the question you had more clearly, that the test needs to use the UI components in the Plugin Management page, and not change settings through the backend. Thank you for pointing that out. I've added the notes in the TM4J test cases that the settings need to change through the UI.
marianunez
reviewed
Aug 28, 2020
e2e/cypress/integration/plugins/marketplace/marketplace_spec.js
Outdated
Show resolved
Hide resolved
prapti
reviewed
Sep 1, 2020
e2e/cypress/integration/plugins/marketplace/marketplace_spec.js
Outdated
Show resolved
Hide resolved
prapti
approved these changes
Sep 16, 2020
|
/update-branch |
DHaussermann
added
4: Reviews Complete
amyblais
added
Changelog/Not Needed
jfrerich
pushed a commit
that referenced
this pull request
Oct 23, 2020
…lugins" is true" (#6295) * MM-T1960 Marketplace is available when "Enable Plugins" is true * remove redundant check for marketplace visibility * remove extra test * Use system console to toggle config values * lint Co-authored-by: Mattermod <[email protected]>
calebroseland
pushed a commit
that referenced
this pull request
Oct 27, 2020
…lugins" is true" (#6295) * MM-T1960 Marketplace is available when "Enable Plugins" is true * remove redundant check for marketplace visibility * remove extra test * Use system console to toggle config values * lint Co-authored-by: Mattermod <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I fixed some "Marketplace should not be visible" tests, which seemed to have been altered in this PR to not check for visibility. I also implemented the Marketplace is available when “Enable Marketplace” is set to true test.
The two tests I added are identical
Ticket Link
https://mattermost.atlassian.net/browse/MM-27831