This repository has been archived by the owner on Mar 13, 2024. It is now read-only.
MM-28101 Fix incorrect link in new sidebar Copy Link option #6291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hmhealey
added
2: Dev Review
Willyfrog
approved these changes
Aug 27, 2020
jgilliam17
added
the
Setup Cloud Test Server
jgilliam17
approved these changes
Aug 27, 2020
There was a problem hiding this comment.
Thank you @hmhealey
Tested, looks good to merge.
- Verified channel Copy Link option copies the link correctly without an extra slash
jgilliam17
added
QA Review Done
and removed
3: QA Review
|
Test server destroyed |
amyblais
added
the
4: Reviews Complete
amyblais
added
Changelog/Done
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a more targeted version of #6290, specific to 5.27. It doesn't include any tests since those required me to go a bit out of scope on this ticket.
Ticket Link
https://mattermost.atlassian.net/browse/MM-28101
Related Pull Requests
#6290 (for 5.28 and beyond)