[MM-28408]Add e2e to test disabling textbox in archived channel MM-T1716 #6289
Conversation
There was a problem hiding this comment.
Thanks @sudheerDev. Overall the test looks great. Suggested some minor changes.
| // Stage: @prod | ||
| // Group: @channel | ||
|
|
||
| import {testWithConfig} from '../../../support/hooks'; |
There was a problem hiding this comment.
Correct path:
import {testWithConfig} from '../../support/hooks';
There was a problem hiding this comment.
Based on the folder structure this is actually right from this folder. I am not a fan of relative URLs when it exceeds more than ../ but as I mostly saw the usage with the relative path I went with it.
There was a problem hiding this comment.
@sudheerDev the Cypress test does not runs as the path is not correct. Can you please fix the correct path. It should be ../../support/hooks. Only then the test works fine. Else we see this error.
There was a problem hiding this comment.
Wierd it was working for me earlier.
e2e/cypress/integration/archived_channel/archive_channel_post_spec.js
Outdated
Show resolved
Hide resolved
e2e/cypress/integration/archived_channel/archive_channel_post_spec.js
Outdated
Show resolved
Hide resolved
e2e/cypress/integration/archived_channel/archive_channel_post_spec.js
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Thank you @sudheerDev
Looks good to merge.
- Test case, steps, details and links updated.
e2e/cypress/support/ui_commands.js
Outdated
| @@ -432,3 +432,10 @@ Cypress.Commands.add('checkRunLDAPSync', () => { | |||
| } | |||
| }); | |||
| }); | |||
|
|
|||
| Cypress.Commands.add('archiveCurrentChannel', () => { | |||
There was a problem hiding this comment.
oh! I think we both have a ui command for archive current channel, we might need to remove one at some point (but they are almost the same, different placement though)
/cc @saturninoabril
There was a problem hiding this comment.
Yeah, I think the one you have is what we'll use moving forward. So if it gets merged first, then I'd suggest to update and use it in this PR 😄
There was a problem hiding this comment.
Changed it to use the other method
Summary
Add e2e tests for check if textboxes are disabled for archived channels
Add a utility for archiving channels
Add a folder for organizing archive channel tests
PS: Ticket MM-27211 has multiple TM4J tests but this PR is for the first one alone MM-T1716
Ticket Link
Story: https://mattermost.atlassian.net/browse/MM-27211
Subtask: https://mattermost.atlassian.net/browse/MM-28408