This repository has been archived by the owner on Mar 13, 2024. It is now read-only.
MM-T402 - Finish Tutorial #6288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saturninoabril
approved these changes
Aug 28, 2020
There was a problem hiding this comment.
Thanks @josephk96! Tested and passed. LGTM, except for last comment. Approving the PR.
josephbaylon
suggested changes
Aug 28, 2020
There was a problem hiding this comment.
Thanks @josephk96 !! Test passed locally. Please resolve conflicts before I retest and approve.
|
/update-branch |
|
Error trying to update the PR. |
|
/update-branch |
josephbaylon
approved these changes
Sep 1, 2020
There was a problem hiding this comment.
LGTM. @josephk96 I resolved the conflicts and will merge PR
jfrerich
pushed a commit
that referenced
this pull request
Oct 23, 2020
* Initial commit for MM-T402 * Complete e2e test functionality for MM-T402 * Refactor MM-T402 to use imported generateRandomUser function * Disable LDAP in MM-T402 * Destructure user properties directly from generateRandomUser function Co-authored-by: Joseph Baylon <[email protected]> Co-authored-by: Mattermod <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This e2e test does the following -
I disabled LDAP (not sure if necessary, but just in case) for this test. After clicking the pulsating tooltip(s), I initially attempted to verify that the correct text was being shown via Testing Library's
findByTextmethod, but it was failing either due to ambiguous text being displayed or because the text was being displayed in many html sub-elements, so I usedcontainsand checked for a part of each tutorial paragraph.I did not save the text I tested in variables because they were not being reused, but let me know if you think that I should :)
Test case: https://automation-test-cases.vercel.app/test/MM-T402