Skip to content
This repository has been archived by the owner on Mar 13, 2024. It is now read-only.

MM-T400 Create account from login page link using email-password #6277

Merged
merged 7 commits into from
Sep 4, 2020
Merged

MM-T400 Create account from login page link using email-password #6277

merged 7 commits into from
Sep 4, 2020

Conversation

josephk96
Copy link
Contributor

Summary

This test ensures that signing up with email verification set to true works.

Test case: https://automation-test-cases.vercel.app/test/MM-T400

@jfrerich jfrerich added 2: Dev Review Requires review by a core commiter 3: QA Review Requires review by a QA tester labels Aug 26, 2020
saturninoabril
saturninoabril suggested changes Aug 27, 2020
View reviewed changes
Copy link
Member

@saturninoabril saturninoabril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@josephk96 Thanks and looking good so far. I'd suggests to resolve the other PRs since some of comments there are applicable here. Also, please let me know the test is passing on you.

e2e/cypress/integration/onboarding/login_page_link_account_creation_spec.js Outdated Show resolved Hide resolved
e2e/cypress/integration/onboarding/login_page_link_account_creation_spec.js Show resolved Hide resolved
e2e/cypress/integration/onboarding/login_page_link_account_creation_spec.js Outdated Show resolved Hide resolved
josephbaylon
josephbaylon suggested changes Aug 27, 2020
View reviewed changes
Copy link
Contributor

@josephbaylon josephbaylon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @josephk96 , I'm experiencing intermittent timeout failures on different parts of the test but mostly pass when I re-run it multiple times. I suggest to run it multiple times as well to catch some of the timeout issues. I think I had it after the getEmail(..) call which visits a page but the element check after doesn't have a long enough timeout -- not sure 'cause I couldn't repro that part anymore but worthwhile to have a proper check to make sure page is loaded after a cy.visit(..) call

@josephbaylon
Copy link
Contributor

/update-branch

@josephbaylon josephbaylon self-requested a review September 2, 2020 16:14
josephbaylon
josephbaylon suggested changes Sep 2, 2020
View reviewed changes
Copy link
Contributor

@josephbaylon josephbaylon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@josephk96 This passes for me consistently locally now. I'll wait for the update to integrate changes from other PRs

@josephk96 josephk96 force-pushed the MM-T400-login-page-link-account-creation branch from ff77bbf to 795dc99 Compare September 3, 2020 12:38
saturninoabril
saturninoabril suggested changes Sep 3, 2020
View reviewed changes
Copy link
Member

@saturninoabril saturninoabril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @josephk96! All looks good except for minor suggestions.

e2e/cypress/integration/onboarding/login_page_link_account_creation_spec.js Outdated Show resolved Hide resolved
e2e/cypress/integration/onboarding/login_page_link_account_creation_spec.js Outdated Show resolved Hide resolved
e2e/cypress/fixtures/timeouts.js Outdated Show resolved Hide resolved
@josephk96 josephk96 force-pushed the MM-T400-login-page-link-account-creation branch from 60dbbe1 to 2f69709 Compare September 3, 2020 13:06
josephbaylon
josephbaylon approved these changes Sep 3, 2020
View reviewed changes
Copy link
Contributor

@josephbaylon josephbaylon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Changes look good and test passed. Thanks @josephk96

saturninoabril
saturninoabril approved these changes Sep 4, 2020
View reviewed changes
Copy link
Member

@saturninoabril saturninoabril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @josephk96! Tested and passed.

@saturninoabril saturninoabril added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core commiter 3: QA Review Requires review by a QA tester labels Sep 4, 2020
@saturninoabril saturninoabril merged commit 604c0fa into mattermost:master Sep 4, 2020
@amyblais amyblais added Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation labels Sep 6, 2020
jfrerich pushed a commit that referenced this pull request Oct 23, 2020
@josephk96 @mattermod @jfrerich
MM-T400 Create account from login page link using email-password (#6277)
311e83f 
* Initial commit for MM-T400

* Add FORTY_FIVE_SEC timeout

* Implement suggested changes to MM-T400

* Remove newly created timeout & use ONE_MIN timeout

Co-authored-by: Mattermod <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@josephbaylon josephbaylon josephbaylon approved these changes

@saturninoabril saturninoabril saturninoabril approved these changes

Assignees
No one assigned
Labels
4: Reviews Complete All reviewers have approved the pull request Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation Hackfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@josephk96 @josephbaylon @saturninoabril @jfrerich @amyblais @mattermod