-
Notifications
You must be signed in to change notification settings - Fork 2.7k
MM-T385 invite new user closed team email #6222
MM-T385 invite new user closed team email #6222
Conversation
cd50da5
to
50cd0a0
Compare
50cd0a0
to
c162aff
Compare
e2e/cypress/integration/team_settings/invite_new_user_to_closed_team_using_email_invite_spec.js
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @josephk96 , I'm unable to run the test successfully locally. It's failing on Add or Invite People
step for me. See images below
I believe this test is for MM-T385 (instead of MM-T388). I've updated the title and description. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @josephk96. Please see comments.
e2e/cypress/integration/team_settings/invite_new_user_to_closed_team_using_email_invite_spec.js
Outdated
Show resolved
Hide resolved
e2e/cypress/integration/team_settings/invite_new_user_to_closed_team_using_email_invite_spec.js
Outdated
Show resolved
Hide resolved
e2e/cypress/integration/team_settings/invite_new_user_to_closed_team_using_email_invite_spec.js
Outdated
Show resolved
Hide resolved
Thanks @josephbaylon and @saturninoabril for the feedback. I asked a question here - https://community.mattermost.com/core/pl/mqxrcsdyqi8xzqekwi8d6piqec regarding how to set up EE on my local machine. After I would be able setup EE on my local machine, I will implement the changes that were suggested and make sure that the test would work for both the licensed and the non-licensed versions |
@josephk96 Thanks and sorry to confuse you. I replied to your question there. Please implement the change as I suggested and try to run against your local setup. If that works for you then I'm all good since I initially tested it with/without license too. |
I implemented the changes that you suggested and changed the test file name to make it more concise. Please let me know if the test is still not working as intended. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @josephk96, LGTM!
/update-branch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Test is now passing for me locally. Thanks @josephk96 !!
Will try to auto merge this PR once all tests and checks are passing. This might take up to an hour. |
Summary
This test creates a closed team and invites an unregistered user via email link to join the team and checks that the email was correctly sent with the proper content and the user was able to join the team after signing up with the link provided in the email.
GitHub Link: mattermost/mattermost#15258
Test case: https://automation-test-cases.vercel.app/test/MM-T385