Skip to content
This repository has been archived by the owner on Mar 13, 2024. It is now read-only.

MM-T385 invite new user closed team email #6222

Conversation

josephk96
Copy link
Contributor

@josephk96 josephk96 commented Aug 20, 2020

Summary

This test creates a closed team and invites an unregistered user via email link to join the team and checks that the email was correctly sent with the proper content and the user was able to join the team after signing up with the link provided in the email.

GitHub Link: mattermost/mattermost#15258
Test case: https://automation-test-cases.vercel.app/test/MM-T385

@josephk96 josephk96 force-pushed the MM-T388-invite-new-user-closed-team-email branch from cd50da5 to 50cd0a0 Compare August 20, 2020 15:36
@josephk96 josephk96 force-pushed the MM-T388-invite-new-user-closed-team-email branch from 50cd0a0 to c162aff Compare August 20, 2020 15:37
@saturninoabril saturninoabril added 2: Dev Review Requires review by a core commiter 3: QA Review Requires review by a QA tester Hackfest labels Aug 21, 2020
Copy link
Contributor

@josephbaylon josephbaylon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @josephk96 , I'm unable to run the test successfully locally. It's failing on Add or Invite People step for me. See images below
Screen Shot 2020-08-21 at 10 48 03 AM

Screen Shot 2020-08-21 at 10 47 39 AM

@saturninoabril saturninoabril changed the title MM-T388 invite new user closed team email MM-T385 invite new user closed team email Aug 22, 2020
@saturninoabril
Copy link
Member

I believe this test is for MM-T385 (instead of MM-T388). I've updated the title and description.

Copy link
Member

@saturninoabril saturninoabril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @josephk96. Please see comments.

@josephk96
Copy link
Contributor Author

josephk96 commented Aug 22, 2020

Thanks @josephbaylon and @saturninoabril for the feedback. I asked a question here - https://community.mattermost.com/core/pl/mqxrcsdyqi8xzqekwi8d6piqec regarding how to set up EE on my local machine. After I would be able setup EE on my local machine, I will implement the changes that were suggested and make sure that the test would work for both the licensed and the non-licensed versions

@saturninoabril
Copy link
Member

@josephk96 Thanks and sorry to confuse you. I replied to your question there. Please implement the change as I suggested and try to run against your local setup. If that works for you then I'm all good since I initially tested it with/without license too.

@josephk96
Copy link
Contributor Author

I implemented the changes that you suggested and changed the test file name to make it more concise. Please let me know if the test is still not working as intended.

Copy link
Member

@saturninoabril saturninoabril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @josephk96, LGTM!

@saturninoabril saturninoabril added 4: Reviews Complete All reviewers have approved the pull request 3: QA Review Requires review by a QA tester and removed 2: Dev Review Requires review by a core commiter 3: QA Review Requires review by a QA tester 4: Reviews Complete All reviewers have approved the pull request labels Aug 23, 2020
@josephbaylon
Copy link
Contributor

/update-branch

@josephbaylon josephbaylon self-requested a review August 24, 2020 16:02
Copy link
Contributor

@josephbaylon josephbaylon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Test is now passing for me locally. Thanks @josephk96 !!

@josephbaylon josephbaylon added 4: Reviews Complete All reviewers have approved the pull request AutoMerge used by Mattermod to merge PR automatically and removed 3: QA Review Requires review by a QA tester labels Aug 24, 2020
@mattermod
Copy link
Contributor

Will try to auto merge this PR once all tests and checks are passing. This might take up to an hour.

@josephbaylon josephbaylon removed the AutoMerge used by Mattermod to merge PR automatically label Aug 24, 2020
@josephbaylon josephbaylon merged commit 190aa62 into mattermost:master Aug 24, 2020
@amyblais amyblais added Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation labels Aug 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
4: Reviews Complete All reviewers have approved the pull request Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation Hackfest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants