Skip to content
This repository has been archived by the owner on Mar 13, 2024. It is now read-only.

MM-27443 disable ESlint jQuery checks for e2e tests #6210

Merged
merged 1 commit into from
Aug 21, 2020
Merged

MM-27443 disable ESlint jQuery checks for e2e tests #6210

merged 1 commit into from
Aug 21, 2020

Conversation

CEOehis
Copy link
Contributor

@CEOehis CEOehis commented Aug 19, 2020

Summary

This PR turns off ESLint jQuery rules for the e2e folder since Cypress exposes jQuery by default.
Also eslint-disable comments for those rules are removed

Ticket Link

Fixes mattermost/mattermost#15164

@hmhealey hmhealey added the 2: Dev Review Requires review by a core commiter label Aug 20, 2020
@hmhealey hmhealey changed the title MM-7443 disable ESlint jQuery checks for e2e tests MM-27443 disable ESlint jQuery checks for e2e tests Aug 20, 2020
hmhealey
hmhealey approved these changes Aug 20, 2020
View reviewed changes
Copy link
Member

@hmhealey hmhealey left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! It's a bit annoying that we have to list all those rules, but we'll be able to remove them eventually once the rest of the JQuery usage outside the E2E tests is cleaned up.

saturninoabril
saturninoabril approved these changes Aug 21, 2020
View reviewed changes
Copy link
Member

@saturninoabril saturninoabril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @CEOehis!

@saturninoabril saturninoabril added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core commiter labels Aug 21, 2020
@saturninoabril saturninoabril merged commit adf907b into mattermost:master Aug 21, 2020
@amyblais amyblais added Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation labels Aug 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hmhealey hmhealey hmhealey approved these changes

@saturninoabril saturninoabril saturninoabril approved these changes

Assignees
No one assigned
Labels
4: Reviews Complete All reviewers have approved the pull request Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation
Projects
None yet
Milestone
No milestone
4 participants
@CEOehis @hmhealey @saturninoabril @amyblais