This repository has been archived by the owner on Mar 13, 2024. It is now read-only.
[MM-27738] Reset after patch #6209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devinbinnie
approved these changes
Aug 19, 2020
mkraft
approved these changes
Aug 20, 2020
srkgupta
suggested changes
Aug 20, 2020
There was a problem hiding this comment.
Hi @hahmadia
The issue is partially fixed now. Can you please check and fix this.
Here's what does not works:
- Link the Group for first time and then click on Edit.
- Now enable the Group Mentions and save.
- Now try to add a team/channel and then save again.
Notice the same invalid error is displayed.
Here's when this fix works:
- Click on Edit for a Group for which Group mention is already enabled.
- Add a Team/Channel and save.
Notice: There are no errors displayed this time after this PR.
srkgupta
approved these changes
Aug 20, 2020
There was a problem hiding this comment.
Sorry @hahmadia. For some reason it did not work fine on my local instance previously. I tested this again on the cloud test instance and the issue is working fine there. The issue is fixed and is working fine. Approving the PR.
|
Test server destroyed |
|
Test server creation failed. See the logs for more information. |
mattermost-build
pushed a commit
to mattermost-build/mattermost-webapp
that referenced
this pull request
Aug 20, 2020
* Reset after patch * return false if server error occured * fix linting (cherry picked from commit 18531fc)
mattermod
pushed a commit
that referenced
this pull request
Aug 20, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Reset
hasAllowReferenceChangedandhasGroupMentionNameChangedto false after a successful patch. Otherwise, keep it at the value it is.Ticket Link
https://mattermost.atlassian.net/browse/MM-27738