This repository has been archived by the owner on Mar 13, 2024. It is now read-only.
MM-T1447 Images below a min-width and min-height are posted in a container that is clickable #6144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e2e/cypress/integration/files_and_attachments/image_link_preview_spec.js
Outdated
Show resolved
Hide resolved
…ew_spec.js Co-authored-by: Saturnino Abril <[email protected]>
saturninoabril
suggested changes
Aug 17, 2020
There was a problem hiding this comment.
I've looked at the given images in the test case and I found those as not sufficient to test image attachment below minimum height or width. With that, I've updated the images. Please revisit MM-T1447. Sorry about that.
Overall, the test flow looks good. Please see comments.
e2e/cypress/integration/files_and_attachments/image_link_preview_spec.js
Outdated
Show resolved
Hide resolved
e2e/cypress/integration/files_and_attachments/image_link_preview_spec.js
Outdated
Show resolved
Hide resolved
e2e/cypress/integration/files_and_attachments/image_link_preview_spec.js
Outdated
Show resolved
Hide resolved
e2e/cypress/integration/files_and_attachments/image_link_preview_spec.js
Outdated
Show resolved
Hide resolved
e2e/cypress/integration/files_and_attachments/image_link_preview_spec.js
Outdated
Show resolved
Hide resolved
saturninoabril
approved these changes
Aug 24, 2020
There was a problem hiding this comment.
@M-ZubairAhmed, thanks for updating! Tested and passed. Left non-blocking comment.
e2e/cypress/integration/files_and_attachments/image_link_preview_spec.js
Outdated
Show resolved
Hide resolved
prapti
approved these changes
Aug 27, 2020
There was a problem hiding this comment.
Looks great and all tests passed.
Thank you again for this contribution @M-ZubairAhmed!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Ticket Link
none
Related Pull Requests
none
Screenshots
none